Hi, > - went ahead and changed the C++ reserved words (hope that's ok Christoph) > from delete to del and class to w_class
The w_class thing is OK, the delete -> del one I don't like at all- I'd like to keep function names in C the same as in SCI whenever possible, except for potential prefix/suffix stuff (particularly for selectors, so that you can just do GET_SELECTOR(obj, foo) if you want to get selector foo and don't have to look up its C representation first). You can leave it as is for the time being, I'll try to think of something else when time permits. > - Christoph: you mentioned that a particular file looked strange, please let > me know what you meant as the 'refactoring' :) should be finished now. The refactorable stuff is either gone now or I mis-interpreted it last time, but there's still a massive if-then-(else-if-)* block in sound_command_default() (sound.c) in place of the switch() statement that used to be there which I don't understand. BTW, right now it hangs here: #0 0x20000b075b8 in write () from /lib/libc.so.6.1 #1 0x200003e15d4 in write () from /lib/libpthread.so.0 #2 0x12008e394 in checked_write () at polled_ss_unix.c:89 #3 0x12008ef40 in sound_unix_send_data (maxsend=18996) at polled_ss_unix.c:382 #4 0x120086250 in sound_command_default () at sound.c:140 #5 0x12001ee64 in kDoSound () at ksound.c:145 #6 0x120021cd0 in run_vm () at vm.c:795 #7 0x120025578 in _game_run (restoring=539910608) at vm.c:1592 #8 0x1200258e0 in game_run () at vm.c:1656 #9 0x12000b630 in main () at main.c:1106 #10 0x20000a3900c in __libc_start_main () from /lib/libc.so.6.1 (i.e. the UNIX port is broken ATM, happens the first time DoSound is called). llap, Christoph
