Richard Shaw <[email protected]> writes:

> On Mon, Apr 15, 2013 at 7:22 PM, Greg Troxel <[email protected]> wrote:

>> automake has a notion where typically generated files are not checked
>> in, and there is a 'make dist' process to build a release tarball from a
>> VCS checkout (typically tagged).   I think this makes sense separately
>> From using automake and should continue; checking in generated files is
>> awkward.  It may be that with a 100% cmake world there are fewer
>> generated files.
>
> I'm assuming when you say to not check in typically generated files you
> don't mean configure or config.h, right? I'm the Fedora packager for
> several autoconf type projects but I've never had to run autoheader before
> to get a build completed.

I mean configure, Makefile.in, config.h.in, and things like that.  They
belong in the distribution tarball but not in the source control system.

> If that's the case and if the svn revision something that we really want to
> capture, is there a way to dump that into config.h during/prior to the
> export? That way the svn files don't make it into the source archive.

Generally I've seen a mixed approach, where a release has the release
version number.  That's from a release tarball that does not have any
svn metadata files (because it was made from make dist).  But, when
building from a checkout, there is sometimes code in configure or
whatever that runs 'svn info' or some such and writes it to a version.h
file.  The basic idea is to have two code paths, one from svn builds and
one for releases.

> I'm already testing for most of them, and I've even started on the cmake
> version of config.h, it's actually pretty easy now that I've looked into
> it, but if a function or header is required, meaning we don't provide a
> workaround in case it's not available, then my vote would be to test
> for existence and error out if it's not available and skip putting the
> result in config.h.

The real question in each case is if it's required by POSIX, and if it's
in fact widely available.   Often Linuxisms creep into code that should
be portable.

> Most of what I found seems to be doing different things based on the type
> of compiler more so than based on the OS so it looks pretty good there. I
> did see any HAVE_... is any #ifdef's when grepping through the source.

That makes sense, and it sounds like you are well on the way.

Attachment: pgpece5jnnZuz.pgp
Description: PGP signature

------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Freetel-codec2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freetel-codec2

Reply via email to