On Wed, Sep 11, 2013 at 10:07 PM, Maitland Bottoms <[email protected]> wrote:
> FYI,
>
> Last changes to http://files.freedv.org/debian/
> were 0.96.5 Revision 1328 packaged into .debs
> for Debian and Ubuntu systems done 31 August 2013.
>
> I figure I should explain some of the additional
> 8 patches I've added to make those work.
>
> 1. Update-SVN-repository-URL
> It appears there was a migration of subversion URLs
> over at sourceforge.net. So I went ahead and
> replaced references to the old location with the
> new location. I expect that a similar patch would
> be part of a Revision 1329 commit.
>
Looks good to me.
> 2. debian-build-svn-version
> Building packages outside of subversion checkout directories
> led me to make a patch to allow defining a revision number
> as part of Cmake configuration.
>
Yes, until we get to true release tags, I would like to see the SVN
revision stored somewhere...
> 3. debian-desktop
> Adjust fields in the contrib/freedv.desktop file to
> fit Debian conventions better.
>
The desktop file is just something I threw together for Fedora... I agree
the your Categories are more appropriate but I'm interested in the absolute
path for the Exec tag... That's definitly the opposite of the Fedora/RH
convention.
> 4. fix-config-include
> Just deleteing a "../" - doesn't that cause trouble for
> others building this code?
>
It doesn't cause any problems for me and it probably shouldn't for you
since you're using cmake... _NO_AUTOTOOLS should be defined for the cmake
build and that line ignored. I need to make sure that's in svn and not just
a local patch I'm running.
5. convenience-copies
> and
> 8. link-with-libXxf86vm
> These should probably have been merged into a single patch.
> The Debian source package has tarballs of convenience copies
> of wxwidgets 2.9.5 and libctb as well as codec2. These changes
> to CMakeLists.txt allow those to be used directly rather than
> fetching from the net and building. Since these are quite
> specific to Debian I would not expect these changes to be
> applied to freedv's repository.
>
I think that's a matter of how you want to build the packages. I use mock
(auto builds under chroot) to build FreeDV so during build wxGTK, libctb, &
codec2 to are "installed" and then of course all those packages are also in
the FreeDV Fedora repository.
Looking at the patch you may be hacking it much more than necessary... For
instance:
- set(USE_STATIC_WXWIDGETS FALSE CACHE BOOL+ # Debian package
handles bootstrap build of static wx-2.9+ set(USE_STATIC_WXWIDGETS
TRUE CACHE BOOL
A patch seems overkill when you could just specify
-DUSE_STATIC_WXWIDGETS=TRUE on the cmake command line.
Perhaps calling this option STATIC is a little misleading...
I'm only looking at your patch right now not the whole file but my thinking
is that there may be a better way to do this. I don't think you need to be
hacking this at all, at least for wxWidgets. If you do a static build of
wxGTK then just set the WXCONFIG value appropriately. If you've only done a
static build of wxGTX then that is what wx-config should return. I'm doing
a static build of wxGTK to test this theory now.
Doing a link test of libctb is something I copied over from the autotools
build. Is it expected to fail with your build method?
> 6. debug-stop-crash
> Just a hack I found necessary when linking with Debian's
> hamlib libraries. The small memory leak of not calling
> free is preferred to crashing the program.
>
I haven't noticed any problems on Fedora but I'm using serial PTT... Does
this only show up if you actually enable hamlib?
> 7. HID-PTT
> This allows use of USB radio interface devices based upon
> Cmedia sound chips that expose I/O pind using an HID device.
> On Linux, a /dev/hidrawX device shows up. This patch only
> works under Linux at this time.
>
Looks good to me but I'm not much of a coder, just a packager.
Richard
KF5OIM
------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. Consolidate legacy IT systems to a single system of record for IT
2. Standardize and globalize service processes across IT
3. Implement zero-touch automation to replace manual, redundant tasks
http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
_______________________________________________
Freetel-codec2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freetel-codec2
