Hi Richard, Further to this Mooneer and I have released codec2 1.0.4_rc2 - hopefully it resolves the interleave_frames' issue in this thread. If not - please raise an issue on GitHub.
Thanks, David On Sun, 2022-07-10 at 07:07 +0930, david wrote: > Hi Richard, > > Looks like the variable 'interleave_frames' has been removed (it was > unused for some time) in 1.0.4 > > 1.0.4 might have been released prematurely - the 2020B/C modes are > still experimental and now I can see the API has been temporarily > hacked to support that experimentation (by me, earlier this year). > > 1.0.4 was pushed out quickly just to support a recent freedv-gui > release. > > Perhaps in this case we need a notation for interim releases to > signal > users outside of freedv-gui shouldn't be using a codec2 release (like > a > beta tag). Or a more formal release procedure that catches issues > like > breaking other applications due to API changes. > > As an aside there is no need for sdr angel or GNU radio to be using > freedv_open_advanced(), they should be using freedv_open(). > freedv_open_advanced() is only used for data applications. > > Cheers, > David > > On Sat, 2022-07-09 at 11:45 -0500, Richard Shaw wrote: > > Trying to rebuild codec2 deps with version 1.0.4 and ran into this > > issue with gnuradio and sdrangel... > > > > /builddir/build/BUILD/gnuradio-3.10.3.0/gr- > > vocoder/lib/freedv_rx_ss_impl.cc: In constructor > > 'gr::vocoder::freedv_rx_ss_impl::freedv_rx_ss_impl(int, float, > > int)': > > /builddir/build/BUILD/gnuradio-3.10.3.0/gr- > > vocoder/lib/freedv_rx_ss_impl.cc:41:15: error: 'struct > > freedv_advanced' has no member named 'interleave_frames' > > 41 | d_adv.interleave_frames = interleave_frames; > > | ^~~~~~~~~~~~~~~~~ > > /builddir/build/BUILD/sdrangel- > > 7.4.0/plugins/channelrx/demodfreedv/freedvdemodsink.cpp: In member > > function 'void > > FreeDVDemodSink::applyFreeDVMode(FreeDVDemodSettings::FreeDVMode)': > > /builddir/build/BUILD/sdrangel- > > 7.4.0/plugins/channelrx/demodfreedv/freedvdemodsink.cpp:436:13: > > error: 'struct freedv_advanced' has no member named > > 'interleave_frames' > > 436 | adv.interleave_frames = 1; > > | ^~~~~~~~~~~~~~~~~ > > > > Thanks, > > Richard > > KF5OIM > > _______________________________________________ > > Freetel-codec2 mailing list > > Freetel-codec2@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/freetel-codec2 > > > _______________________________________________ > Freetel-codec2 mailing list > Freetel-codec2@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/freetel-codec2 _______________________________________________ Freetel-codec2 mailing list Freetel-codec2@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freetel-codec2
