Hello,

thanks a lot for your work. Can you add some clarification to the ChangeLog
of the first patch that explain why it is needed ?

Regarding the second patch, the internal code uses the convention of naming
functions as:

object_method( Object*  o, .... )

It would be nicer if you could keep the convention instead of prepending an
extra FT_Library parameter at the start of the
function. Indeed, you should instead store the FT_Library handle into the
CFF_Parser object and pass it to cff_parser_init,
then re-use it in subsequent functions. This will make the code much
clearer.

2009/3/18 Oran Agra <[email protected]>

> I'm working in my local master branch so I guess 'git rebase' is not
> necessary.
>
> Attached are first two patches that are not related to PIC.
> Please tell me if the comments and git patches are ok.
>
> I'll add the documentation you requested.
> And I've verified that VS2005 and VS6 are compiling the PIC code including
> all the macros.
>
>
> _______________________________________________
> Freetype-devel mailing list
> [email protected]
> http://lists.nongnu.org/mailman/listinfo/freetype-devel
>
>
_______________________________________________
Freetype-devel mailing list
[email protected]
http://lists.nongnu.org/mailman/listinfo/freetype-devel

Reply via email to