On Sun, Jul 7, 2019 at 12:23 AM Moazin Khatri <moazinkha...@gmail.com> wrote: > > >> > `SVG_RendererRec' is a module that inherits from `FT_RendererRec'. This >> > was done so that I can add a new field for storing the `hooks'. >> >> Some hooks in SVG_RendererRec should be hosted in parent FT_ModuleRec. It >> seems unnecessary. > > > Please elaborate which hooks you think can be hosted in the parent > `FT_ModuleRec' and where exactly in `FT_ModuleRec' could they be stored?
See in the comments: typedef struct SVG_RendererHooks_ { /* Api Hooks for OT-SVG Rendering */ SVG_Lib_Init svg_lib_init; /* FT_Renderer->clazz->root.module_init */ SVG_Lib_Free svg_lib_free; /^ FT_Renderer->clazz->root.module_done */ SVG_Lib_Render svg_lib_render; /* FT_Renderer->clazz->render_glyph */ SVG_Lib_Get_State_Size svg_lib_get_state_size; /* FT_Renderer->clazz->root.module_size ? */ SVG_Lib_Get_Buffer_Size svg_lib_get_buffer_size; } SVG_RendererHooks; typedef struct SVG_RendererRec_ { FT_RendererRec root; /* This inherits FT_RendererRec */ FT_Bool loaded; SVG_RendererHooks hooks; /* Holds out hooks to the outside library */ } SVG_RendererRec; -- Alexei A. Podtelezhnikov, PhD _______________________________________________ Freetype-devel mailing list Freetype-devel@nongnu.org https://lists.nongnu.org/mailman/listinfo/freetype-devel