Hi Alexei, On Sat, Aug 1, 2020 at 5:42 PM Alexei Podtelezhnikov <[email protected]> wrote:
> Hi Werner et al., > > Please review the patch if you agree with the placement of the flag > retention code. > > Hi Dominik. > > Last time you wanted to be warned about expected pixel differences. > Once applied this will produce pixel differences for glyphs with > OVERLAP_SIMPLE and OVERLAP_COMPOUND. > Thanks for the heads-up! This one seems to have gone green on our bots and did not produce pixel differences in our testing at least <https://chromium-review.googlesource.com/c/chromium/src/+/2339196>. It's good to know about these in advance. What I had also requested was a reasonable justification for pixel differences, i.e. a robust benchmark finding, or a robust technical reasoning. Do you have more background than "This might improve rendering of these glyphs."? What was your testing approach? Thanks, Dominik > >
