Duncan Webb wrote: Before the network outage today I was trying to say that this is not the root cause of the problem but something to do with higher up the stack. The bug report: https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1607360&group_id=46652 has the stack trace and the file that caused this problem is here: ftp://ftp.linuxowl.com/ricky_martin_-_Living_la_vida_loca.mpg
The patch prevented the crash and mminfo -d0 reported that data correctly. Duncan > Author: duncan > Date: Sun Dec 3 14:57:11 2006 > New Revision: 2149 > > Modified: > trunk/metadata/src/video/mpeginfo.py > > Log: > When the buffer is empty, it causes a crash in ReadSCRMpeg1 > This fix ensures that crash can't happen. > > > Modified: trunk/metadata/src/video/mpeginfo.py > ============================================================================== > --- trunk/metadata/src/video/mpeginfo.py (original) > +++ trunk/metadata/src/video/mpeginfo.py Sun Dec 3 14:57:11 2006 > @@ -293,6 +293,9 @@ > """ > read SCR (timestamp) for MPEG2 at the buffer beginning (6 Bytes) > """ > + if len(buffer) < 6: > + return -1 > + > highbit = (ord(buffer[0])&0x20)>>5 > > low4Bytes= ((long(ord(buffer[0])) & 0x18) >> 3) << 30 > @@ -313,6 +316,9 @@ > """ > read SCR (timestamp) for MPEG1 at the buffer beginning (5 Bytes) > """ > + if len(buffer) < 5: > + return -1 > + > highbit = (ord(buffer[0]) >> 3) & 0x01 > > low4Bytes = ((long(ord(buffer[0])) >> 1) & 0x03) << 30 > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Freevo-cvslog mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/freevo-cvslog > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Freevo-cvslog mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freevo-cvslog
