Author: dmeyer
Date: Fri Dec 29 20:23:48 2006
New Revision: 2309

Modified:
   trunk/popcorn/src/backends/gstreamer/child.py
   trunk/popcorn/src/generic.py

Log:
provide some doc about pixel-aspect-ratio

Modified: trunk/popcorn/src/backends/gstreamer/child.py
==============================================================================
--- trunk/popcorn/src/backends/gstreamer/child.py       (original)
+++ trunk/popcorn/src/backends/gstreamer/child.py       Fri Dec 29 20:23:48 2006
@@ -142,17 +142,6 @@
             # xaspect = display_aspect[0] * fullscreen[1]
             # yaspect = display_aspect[1] * fullscreen[0]
             # vo.set_property('pixel-aspect-ratio', '%s/%s' % (xaspect, 
yaspect))
-            #
-            # For popcorn we should either get both values to the player
-            # (xaspect, yaspect) or both variables. The later is much easier
-            # for the user to configure.
-            #
-            # Maybe we should create a config option for the monitor aspect
-            # 16/9, 15/9 or 4/3. This is what the user needs. The fullscreen
-            # values could be get during runtime. Maybe we can ask the x server
-            # for the resolution or for non x based code we could ask the given
-            # kaa.display display (fb, dfb). This would be the best choice for
-            # the user.
 
             goom = gst.element_factory_make("goom", "goom0")
             self._gst.set_property('vis-plugin', goom)

Modified: trunk/popcorn/src/generic.py
==============================================================================
--- trunk/popcorn/src/generic.py        (original)
+++ trunk/popcorn/src/generic.py        Fri Dec 29 20:23:48 2006
@@ -100,7 +100,34 @@
             # settings that are set global is most cases
             'postprocessing': False,
             'software-scaler': True,
-            'pixel-aspect-ratio': '1:1', # of the output
+
+            # The pixel-aspect-ratio is set for the output. If both
+            # the screen resolution and the physical resolution of the
+            # monitor / tv are the same, this has to be set to 1:1.
+            # For all other cases this needs to be calculated. Because
+            # kaa.popcorn may not know the real fullscreen resolution
+            # for same displays, simple settings for an aspect like
+            # 4:3 or 16:9 are not possible (and a window may have a
+            # different aspect ratio than the screen itself). And
+            # since a config should work with different X-Server
+            # resolutions this has to be a player property.
+            #
+            # An easy way to calculate this is to use
+            # a1 = display_aspect[0] * fullscreen[1]
+            # a2 = display_aspect[1] * fullscreen[0]
+            # set_property('%s:%s' % (a1, a2)
+            # with display_aspect as physical monitor aspect and
+            # fullscreen the maximum pixels.
+            # So for a 16:9 TV and a 800x600 screen the
+            # pixel-aspect-ratio is 16 * 600 : 9 * 800.
+            #
+            # An application like Freevo who knows the fullscreen size
+            # can offer a simpler way for the user to only provide the
+            # monitor aspect (4:3, 16:9, 15:9 and 15:10)
+            #
+            # Note: the value has to be a string with int values or
+            # gstreamer won't work.
+            'pixel-aspect-ratio': '1:1',
 
             # settings usefull for changing after a stream is
             # loaded.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freevo-cvslog mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-cvslog

Reply via email to