Author: tack
Date: Thu Jan 11 23:13:12 2007
New Revision: 2380

Modified:
   trunk/popcorn/src/backends/mplayer/player.py

Log:
Outbuf and deinterlace filters need to be added even if there's no window.
Also added a couple FIXMEs about the lack of distinction between audio and
video filters.


Modified: trunk/popcorn/src/backends/mplayer/player.py
==============================================================================
--- trunk/popcorn/src/backends/mplayer/player.py        (original)
+++ trunk/popcorn/src/backends/mplayer/player.py        Thu Jan 11 23:13:12 2007
@@ -363,15 +363,6 @@
 
         # create filter list
         filters.extend(self._filters_pre[:])
-        if 'outbuf' in self._mp_info['video_filters']:
-            filters += ["outbuf=%s:yv12" % self._frame_shmkey]
-
-        if self._properties['deinterlace'] == True or \
-               (self._properties['deinterlace'] == 'auto' and \
-                self._media.get('interlaced')):
-            # add deinterlacer
-            filters.append(config.mplayer.deinterlacer)
-
         # FIXME: all this code seems to work. But I guess it has
         # some problems when we don't have an 1:1 pixel aspect
         # ratio on the monitor and using software scaler.
@@ -480,6 +471,17 @@
         if 'x11' in self._mp_info['video_drivers']:
             args.append('-nomouseinput')
 
+        if 'outbuf' in self._mp_info['video_filters']:
+            filters.append("outbuf=%s:yv12" % self._frame_shmkey)
+
+        if self._properties['deinterlace'] == True or \
+               (self._properties['deinterlace'] == 'auto' and \
+                self._media.get('interlaced')):
+            # add deinterlacer
+            filters.append(config.mplayer.deinterlacer)
+
+
+        # FIXME: self._filters_pre / add doesn't get included if no window.
         if self._window:
             self.configure_video()
         else:
@@ -593,6 +595,7 @@
     #
     # Methods for filter handling (not yet in generic and base)
     #
+    # FIXME: no distinction between audio and video filters
 
     def prepend_filter(self, filter):
         """

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freevo-cvslog mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-cvslog

Reply via email to