Author: duncan
Date: Mon Nov 19 14:32:31 2007
New Revision: 10146

Log:
[ 1834275 ] crash in oneclick plugin
Fix applied, the icon number is a '-' which was not handled


Modified:
   branches/rel-1-7/freevo/ChangeLog
   branches/rel-1-7/freevo/src/plugins/oneclick.py
   branches/rel-1/freevo/ChangeLog
   branches/rel-1/freevo/src/plugins/oneclick.py

Modified: branches/rel-1-7/freevo/ChangeLog
==============================================================================
--- branches/rel-1-7/freevo/ChangeLog   (original)
+++ branches/rel-1-7/freevo/ChangeLog   Mon Nov 19 14:32:31 2007
@@ -20,9 +20,10 @@
  * Updated French translation (F#1832751)
  * Updated mplayer to allow the volume events to passed over and shown 
(F#1834486)
  * Renamed plug-in audio.playlist to audio.playlists (B#1834140)
+ * Fixed helper plugins, not allowing tuples as arguments (B#1832837)
  * Fixed itv plug-in, having "No player for this item found" 
(B#1833018,B#1833829)
  * Fixed lastfm plug-in path using /tmp to use FREEVO_CACHEDIR (B#1834488)
- * Fixed helper plugins, not allowing tuples as arguments (B#1832837)
+ * Fixed oneclick weather plug-in not handling bad icon data (B#1834275)
 
 == Release 1.7.4 (2007-11-15) ==
 --------------------------------

Modified: branches/rel-1-7/freevo/src/plugins/oneclick.py
==============================================================================
--- branches/rel-1-7/freevo/src/plugins/oneclick.py     (original)
+++ branches/rel-1-7/freevo/src/plugins/oneclick.py     Mon Nov 19 14:32:31 2007
@@ -736,6 +736,9 @@
         '''obtain the weather icons for multiple day forecast'''
         _debug_('getDayImage()', 2)
 
+        if not WEATHER_ICONS.has_key(num):
+            num = 'na'
+
         icon = os.path.join(WEATHER_SKIN_DIR, WEATHER_ICONS[num][0])
         if not os.path.isfile(icon):
             icon = os.path.join(WEATHER_SKIN_DIR, WEATHER_ICONS[num][1])

Modified: branches/rel-1/freevo/ChangeLog
==============================================================================
--- branches/rel-1/freevo/ChangeLog     (original)
+++ branches/rel-1/freevo/ChangeLog     Mon Nov 19 14:32:31 2007
@@ -25,9 +25,10 @@
  * Updated French translation (F#1832751)
  * Updated mplayer to allow the volume events to passed over and shown 
(F#1834486)
  * Renamed plug-in audio.playlist to audio.playlists (B#1834140)
+ * Fixed helper plugins, not allowing tuples as arguments (B#1832837)
  * Fixed itv plug-in, having "No player for this item found" 
(B#1833018,B#1833829)
  * Fixed lastfm plug-in path using /tmp to use FREEVO_CACHEDIR (B#1834488)
- * Fixed helper plugins, not allowing tuples as arguments (B#1832837)
+ * Fixed oneclick weather plug-in not handling bad icon data (B#1834275)
 
 == Release 1.7.4 (2007-11-15) ==
 --------------------------------

Modified: branches/rel-1/freevo/src/plugins/oneclick.py
==============================================================================
--- branches/rel-1/freevo/src/plugins/oneclick.py       (original)
+++ branches/rel-1/freevo/src/plugins/oneclick.py       Mon Nov 19 14:32:31 2007
@@ -736,6 +736,9 @@
         '''obtain the weather icons for multiple day forecast'''
         _debug_('getDayImage()', 2)
 
+        if not WEATHER_ICONS.has_key(num):
+            num = 'na'
+
         icon = os.path.join(WEATHER_SKIN_DIR, WEATHER_ICONS[num][0])
         if not os.path.isfile(icon):
             icon = os.path.join(WEATHER_SKIN_DIR, WEATHER_ICONS[num][1])

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Freevo-cvslog mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-cvslog

Reply via email to