Bugs item #1618747, was opened at 2006-12-19 13:37 Message generated for change (Comment added) made by duncanwebb You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1618747&group_id=46652
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: plugins Group: 1.x svn >Status: Pending Resolution: Accepted Priority: 5 Private: No Submitted By: Temar (temar) Assigned to: Nobody/Anonymous (nobody) Summary: PATCH: Fix some bugs in IMDB lookup Initial Comment: This patch fixes some bugs in IMDB lookup: - Workaround for UnicodeDecodeError - Fixes "Unknown error while IMDB lookup" when only one hit is returned. - Adds impawards images support again. - Uses "Plot Summary" if no "Plot Outline" is available. This fixes some crashes. I got "UnicodeDecodeError" exceptions with some movies I looked up from IMDB. I was not able to fix this properly but wrote a workaround by trapping these exceptions. They do not seem to affect the final fxd output. When a direct hit was returned from IMDB and not a list of hits I always got a "Unknown Error..." error message. I fixed this by parsing the returned URL and skipping parsing of the multiple-hit return page. I got crashes of the fxdimdb.py module when no "Plot Outline" tag was present. I fixed this by using "Plot Summary" in this case. Some movies do not have at "Plot Outline" tag. I added impawards.com support again as these images are much better. This checks for different image URLs and adds them to the image_urls array. Greets, Temar ---------------------------------------------------------------------- >Comment By: Duncan Webb (duncanwebb) Date: 2006-12-20 00:19 Message: Logged In: YES user_id=104395 Originator: NO Thanks again ---------------------------------------------------------------------- Comment By: Temar (temar) Date: 2006-12-19 17:33 Message: Logged In: YES user_id=1672172 Originator: YES > You may need to check that everything is still okay. I tested the new version with all my problem files. Everything seems to work fine. Greets, Temar ---------------------------------------------------------------------- Comment By: Duncan Webb (duncanwebb) Date: 2006-12-19 14:36 Message: Logged In: YES user_id=104395 Originator: NO Nice, thankyou. Keep up the good work. The patch has been applied to rel-1 at r8746. I modified the patch a little bit, partly because the original version was a bit out of date and some of the was rejected, hopefully because the changes were already in. The if (imdb_result != None): to if imdb_result: this will also catch empty strings. You may need to check that everything is still okay. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1618747&group_id=46652 ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Freevo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freevo-devel
