On Wed, 2007-01-31 at 20:32 +0100, Duncan Webb wrote:
> > +flagged= {}
> > +for flag in FLAGS:
> > + flagged[flag]= frozenset(_[0] for _ in TAGTYPES if _[1] & flag)
> > +
I don't like the look of using _ as a dummy variable. (I know this
isn't your code, just saying.)
> I didn't spot this before but it means that kaa.metadata is no longer
> compatible with Python-2.3.
>
> What does it do anyway?
It constructs a lookup table from a given flag to the support tag types.
I actually don't like the way this is done, and it seems overly obscure.
The 'flagged' dictionary should be setup directly.
FLAGS= CONTAINER, SKIPPER, TAGITEM, IGNORE= [2**_ for _ in xrange(4)]
CALLBACK= TAGITEM
FLAGS.append(CALLBACK)
should be:
CONTAINER, SKIPPER, TAGITEM, IGNORE, CALLBACK = 1, 2, 4, 8, 4
The TAGTYPES tuple isn't really needed; I would setup flagged
explicitly:
flagged = {
CONTAINER: ('dinf', 'mdia', 'stbl', 'udta', 'trak',
'ilst', 'meta', 'minf', 'moov'),
SKIPPER: ('meta',),
...
}
This would solve the python 2.4 dependency.
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Freevo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-devel
