Hi Jason,

On Sunday 04 February 2007 20:56, Jason Tackaberry wrote:
> On Sun, 2007-02-04 at 19:06 +0200, naudefj wrote:
> > Dirk/ Jason, any chance of getting some direction on this?
>
> We talked on IRC a while back and agreed to use kbits.  Agreeing on
> units is easy.  Fixing the damn thing is another matter. :)
>
> Bitrate calculations in many of the parsers are incorrect, and in others
> are completely and unfathomably out to lunch.

I'm referring to a very specific problem that IMHO is release critical to 
Freevo 1.7. The problem can easily be fixed with a simple patch like this:

Index: kaa/metadata/src/audio/ogg.py
===================================================================
--- kaa/metadata/src/audio/ogg.py       (revision 2455)
+++ kaa/metadata/src/audio/ogg.py       (working copy)
@@ -69,6 +69,7 @@
         self.version, self.channels, self.samplerate, bitrate_max, \
                       self.bitrate, bitrate_min, blocksize, \
                       framing = struct.unpack('<IBIiiiBB',info[:23])
+       self.bitrate = self.bitrate / 1000;
         # INFO Header, read Oggs and skip 10 bytes
         h = file.read(4+10+13)
         if h[:4] == 'OggS':

However, this is not the best way of solving the problem. I would really 
appreciate if you can help with a proper fix. 

Best regards.

Frank

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Freevo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to