--- Rob Shortt <[EMAIL PROTECTED]> escreveu: > Wan Tat Chee
wrote:
> > When trying to play a DVD....guess the cleanup isn't complete yet?
> > 
> > Crash!
> > Traceback (most recent call last):
> >   File "src/main.py", line 393, in ?
> >     main_func()
> >   File "src/main.py", line 330, in main_func
> >     osd.focused_app.eventhandler(event)
> >   File "src/menu.py", line 536, in eventhandler
> >     action( menuw=self )
> >   File "src/video/videoitem.py", line 571, in dvd_vcd_title_menu
> >     icon='skins/icons/misc/cdrom_mount.png')
> >   File "src/gui/PopupBox.py", line 170, in __init__
> >     self.set_icon(icon)
> >   File "src/gui/PopupBox.py", line 224, in set_icon
> >     self.icon = pygame.image.load(image).convert_alpha()
> > error: Couldn't open skins/icons/misc/cdrom_mount.png
> 
> I remember not too long ago Aubin mentioned it would be nice to have 
> things like icon paths for various icons inside the skin instead of 
> hardcoding them like this.  I think this is a good idea as well.

I said that after the Dischi iconset attribute to the skin :)


> There was some discussion about it but has anyone come up with a
> decent 
> format for the xml for this?  Once this is in place I can change the 
> PupupBox class to accept a contructor like:
> 
> PopupBox(text='Loading DVD.', icon='cdrom')

IMHO you could do that already, just look for the file in the iconset
dir

 
> Then have it check the skin information for the path to the cdrom
> icon 
> for that skin.
> 
> Sound ok?
> 

Yes, BTW if you have some time, could you try to cleanup the XML from
these kind of hardcoded thing? I'm in a lack of time until next week
Wednesday.

Also, the idea would be to have iconset for skins like:
blurr/64x64
or 
blurr/medium

Gustavo

_______________________________________________________________________
Yahoo! Mail
Mais espa�o, mais seguran�a e gratuito: caixa postal de 6MB, antiv�rus, prote��o 
contra spam.
http://br.mail.yahoo.com/


-------------------------------------------------------
This SF.Net email is sponsored by: INetU
Attention Web Developers & Consultants: Become An INetU Hosting Partner.
Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission!
INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php
_______________________________________________
Freevo-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to