I've been seeing a regular crash.. doesn't seem to crash freevo but maybe it
should be wrapped up in a try except?  I think its just when one inserts
blank media..

Exception in thread Thread-2:
Traceback (most recent call last):
  File "/usr/lib/python2.3/threading.py", line 436, in __bootstrap
    self.run()
  File "/usr/lib/python2.3/site-packages/freevo/plugins/rom_drives.py", line
785, in run
    self.check_all()
  File "/usr/lib/python2.3/site-packages/freevo/plugins/rom_drives.py", line
745, in check_all
    self.identify(media)
  File "/usr/lib/python2.3/site-packages/freevo/plugins/rom_drives.py", line
495, in identify
    disc_info = util.mediainfo.disc_info(media)
  File "/usr/lib/python2.3/site-packages/freevo/util/mediainfo.py", line
616, in disc_info
    type, id  = cdrom_disc_id(media.devicename)
  File "/usr/lib/python2.3/site-packages/mmpython/disc/discinfo.py", line
226, in cdrom_disc_id
    disc_type = cdrom_disc_status(device, handle_mix=handle_mix)
  File "/usr/lib/python2.3/site-packages/mmpython/disc/discinfo.py", line
195, in cdrom_disc_status
      fd = open(device, 'rb')
IOError: [Errno 123] No medium found: '/dev/cdroms/cdrom0'

Its a bit trivial for a patch, but at line 195 i would change:
    fd = open(device, 'rb')
to be this:
    try:
        fd = open(device, 'rb')
    except IOError:
        # cannot open media (probably blank or shot disc)
        return 3


Mick

PS Yay for first improvement ;-)




-------------------------------------------------------
This SF.Net email is sponsored by OSTG. Have you noticed the changes on
Linux.com, ITManagersJournal and NewsForge in the past few weeks? Now,
one more big change to announce. We are now OSTG- Open Source Technology
Group. Come see the changes on the new OSTG site. www.ostg.com
_______________________________________________
Freevo-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to