> This looks good. The only questions, I have are whether we might want > to > use the qp_xml parser rather than dragging another parser in. (but i > also use the Sax2 parser in the tvtime plugin since the qp_xml doesn't > do things i need in that plugin.)
I honestly had no idea which XML parser you were using (this was pretty much a blind fix)--I just looked in the Python docs and found the first thing that looked like it would work (well, second thing--I tried xml.dom just because I was used to DOM, then realized that with the size of the --listxml output that was pretty much unfeasible). Since xml.sax is a standard part of the python distribution, I don't think it's really a problem to use it, but if you'd like, just point me at qp_xml docs and I can rewrite it. > and whether we want to add a main sub that uses the two debugging > comparison functions you put into the code so that we can have > debugging > code in there and give a commandline to run it in case we run into > wierd > problems. That would work too. I really haven't mucked about with freevo internals much, so it'd take a leetle bit for me to do that (I just ripped mame_cache.py out into a standalone file, played with it using fixed values, and merged changes back in after testing). Keep in mind that I'm not sure when --listxml was added to xmame, but as mentioned --listinfo is gone as of 0.84, so I'm not sure how much testing will be needed (ie we only need to make sure --listinfo generates the same results as --listxml for a few versions). I'm more curious at the moment what the deal is with missing keystrokes when xmame games are launched from freevo (as I whined about in the users list). That's an odd one. -->VPutz
signature.asc
Description: Digital signature
