On Tue, 2004-08-10 at 09:41 -0300, Rob Shortt wrote:
> Ok, stop offending me! ;)  The guide achieved my goals at the time and 
> most of it was written over 1.5 years ago as a python newbie.  There has 
> been little motivation to improve it.  Thank you for doing so.

Fair enough. :)  'course, I'm always happy to admit when I write
terrible code.  We all do it, so don't feel bad.  It's just that when
you release it, you risk ridicule by others. :)

> I'm running Mozilla, and I've applied your patch to CVS main branch. 
> There are a few things I need to fix up and I'll commit this in the evening.

I noticed some cruft in proginfo.rpy that I forgot to remove before
diffing.  This stanza:

        t0=time.time()
        guide = tv.epg_xmltv.get_guide()
        t1=time.time()
        (got_schedule, schedule) = ri.getScheduledRecordings()
        if got_schedule:
            schedule = schedule.getProgramList()

Can be reduced to:

        guide = tv.epg_xmltv.get_guide()

Cheers,
Jason.

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to