Hans Meine wrote: > Hi! > > Some time ago, I decided to try out this "Favorites"-feature, so I made > "James > Bond" a favorite at any time on any channel, trying to get a complete James > Bond collection. I wondered why there was no possibility to edit the favorite > title (I mean - not the caption), so I just > edited /var/cache/freevo/record_schedule.xml by hand. > > The bottom line: I found out that "James Bond 007 - Moonraker - Streng > geheim" > was not scheduled for recording, because the full title is compared. I > "fixed" this in helpers/recordserver.py by looking for substring matches: > @@ -622,7 +622,7 @@ class RecordServer(xmlrpc.XMLRPC): > > for fav in favs.values(): > > - if prog.title == fav.title: > + if prog.title.find(fav.title) >= 0: > if fav.channel == > tv_util.get_chan_displayname(prog.channel_id) \ > or fav.channel == 'ANY': > if Unicode(fav.dow) == Unicode(dow) or Unicode(fav.dow) > == u'ANY': > > Now the question is - doesn't this make more sense in general/couldn't this > patch be included? In case that fav.title contains something like "James Bond > 007 - Moonraker - Streng geheim" this would not change anything, but it would > make it possible to automatically record all episodes of TV shows / the > like?!
I don't know, maybe someone wants exact title matching. For 1.5.x I would not change that, but the recordserver in cvs head (a.k.a Freevo 2.0) could get an extra flag for favorites </substring_match> to support this feature. Dischi -- The 50-50-90 rule: Any time you have a 50-50 chance of getting something right, there's a 90% probability you'll get it wrong.
pgpziiH40tZZM.pgp
Description: PGP signature
