Hello all,
I was recently looking at the code in freevo that handles lirc, to try
and find a problem I was having. I use my remote for other things
besides freevo and noticed that buttons that have no function assigned
to them in freevo cause a repetition of whatever the previous action
was. The current code does work, and allows buttons to repeat,
however, I don't think repitition is something freevo should be
handling as lirc can handle it internally.

For example, in my case I have a command that runs through irexec to
change the volume (freevo volume control disabled). So whenever I try
to change the volume while freevo is running, it repeats whatever the
last action was with the remote in freevo.

The current code is assuming that if pylirc.nextcode() returns an
empty list, then it means that the previous button was repeated. This
is indeed what happens, but I think it could be handled a better way.
LIRC supports a repeat parameter in lircrc files that allows a button
to repeat. Pylirc seems to support this (I have 0.0.4) and sends the
name of the button in the list every time (if repeat=1 in lircrc),
instead of just an empty list.

As a solution, I changed get_last_code in rc.py to simply return
self.nextcode. As long as I set the repeat parameters properly in my
lircrc, it works perfectly now.

I'm not sure whether any of this is relevant with the changes in
freevo 2.0 but I wanted to bring it to attention. Sorry if this has
been discussed before, I didn't anything in the archive.

Thanks for a great program,
-Joe Flint


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to