On Mon, 2005-07-11 at 17:28 +0200, Dirk Meyer wrote: > I only have a width of 1024 on my (old) laptop and 1200 on my working > machine. I can't even have a terminal + an emacs with both more than > 80 chars in line next to each other. I know, I just get a new laptop.
Wow, how ... limiting. :)
> vote for addTimer in nf_generic. BUT, in __init__ we could rename it
> to add_timer, I have no problem with that. In fact, I would prefer
> it. AddTimer isn't the way we should do it.
Yes, and also rename addShutdown/removeShutdown, and add wrappers for
(or rename via import) addSocket, removeTimer,
addDispatcher/removeDispatcher.
> Again, I could switch to 80 chars. Since right now everything is from
> one of us plus Rob, I guess we three should define a max width. Please
> not more than 130 beacuse it won't fit. IF we use more than 80, we
> should use 120.
Ok, 80 or 120. ping rshortt. My vote is for 120, of course.
> I prefer the other, it's esier to read. But we could drop this part of
> the rule. I see one problem with copy-paste I see in Freevo all the
> time. E.g. foo.py makes from kaa import imlib2, display, evas and
The Python style guide says:
import os
import sys
from kaa import imlib2, evas, display
So put imports on separate lines, but you can group together "from foo"
imports. I'm fine with that.
> OK, maybe we should use " or maybe we should use what we like? I guess
> not everything needs a rule.
No, as long as everyone can read it no problem.
> freevo event system uses a class Event. BTW, maybe I move some basic
> event handling into kaa.notifier, too. It is different than your
> signals in some ways, so they both are usefull.
How does Event work?
> I guess you simply want to add stdin into the socket callback. Look at
> the notifier doc:
Right. However you first need to setup the terminal so that pull
individual characters from stdin rather than LF-terminated lines. (see
getch_enable).
> No, the signals use weakrefs. That is a good idea, but there was no
> reference to my freevo input plugin anymore and since you on;y had a
> weakref to my callback, keys didn't work. But I fixed it in my lugin
> loader.
Ah. Yeah, it's too easy to make cyclic refs with Signals, so I use
weakrefs for everything, even argument data. I should update to use the
new weakref proxy.
Jason.
signature.asc
Description: This is a digitally signed message part
