On Tue, 2005-08-02 at 15:08 +0200, Dirk Meyer wrote: > OK, so maybe we should remove all the subclassing? Having two ways of > handling the stdout sounds bad to me. BTW, why do you have a Process > in mplayer and not inherit from one?
I don't see a problem with having both, but using signals is the most flexible approach in any case. > But back to the signals. Maybe remove the stdout and stderr functions > to inherit to and also remove the shutdown callback. There isn't much > difference between this callback and to connect to the signal. True. I didn't want to change the existing API since it might break other stuff :) > > add readlines() function to Process class to read lines from process > > immediately rather than going through the notifier loop; > > Why? [...] > This is ugly. Maybe it blocks. Is there a good reason why kaa-mplayer > uses this? It does block, that's the point. See kaa.mplayer.MPlayer constructor: I need to run MPlayer and read some data from it immediately, because if I don't like what I see, I need to raise an exception saying the MPlayer executable doesn't look right. I suppose I could use popen directly for this, if you're really opposed to this addition. Jason.
signature.asc
Description: This is a digitally signed message part
