I have some ogg vorbis files and kaa.metadata isn't picking up the album
tag from them.  I see there are two classes registered with the factory
for .ogg files, OggInfo and OgmInfo.  I think the ogg header is the same
for both cases, so technically OggInfo will parse ogg containers that
hold video, and OgmInfo will parse ogg containers that hold only audio.
As a result, OgmInfo is parsing my ogg audio files, and the album
attribute isn't getting added.

I'm not sure what the best solution to this problem is.  I don't know
the code or the design very well.   But there are three ways to fix my
particular problem:

     1. Add 'album' to MEDIACORE
     2. Import audio.ogginfo after video.ogminfo rather than before it
     3. Have video.ogminfo constructor raise an exception if no video
        stream is found in the ogg container, forcing the factory to
        fall back to audio.ogginfo.

I think #3 is the best approach so I committed the change.  dischi, if
you agree, you can roll it back, but we'd still need a solution to this
problem. :)

Jason.

Attachment: signature.asc
Description: This is a digitally signed message part

Reply via email to