On Wed, 2006-08-09 at 13:46 -0300, Rob Shortt wrote:
> Justin Wetherell wrote:
> > Here's the diff:
> >
> > [EMAIL PROTECTED]:/usr/lib/python2.4/site-packages/kaa/epg# diff
> > source_xmltv.org source_xmltv.py
> > 203c203,213
> > < attr['date'] =
> > int(time.mktime(time.strptime(child.content, fmt)))
> > ---
> >> try:
> >> attr['date'] =
> > int(time.mktime(time.strptime(child.content, fmt)))
> >> except:
> >> log.info('Failed first format type')
> >> continue
> >> fmt = "%Y%m%d"
> >> try:
> >> attr['date'] =
> > int(time.mktime(time.strptime(child.content, fmt)))
> >> except:
> >> log.info('Failed second format type')
> >> continue
>
> Yeah, that works too. :) I see nothing wrong with committing this.
Except for the fact that it's ugly code. :)
It would probably be better to use a dict of regexps to match various
possible date formats. Something like:
DATE_FORMATS = {
"%Y-%m-%d": re.compile("^\d{4}-\d\d-\d\d$"),
"%d-%m-%Y": re.compile("^\d\d-\d\d-\d{4}$"),
# assumes year is always first, but might be wrong.
"%Y%m%d": re.compile("^\d{8}$"),
"%Y": re.compile("^\d{4}$")
}
[...]
for format, regexp in DATE_FORMATS.items():
if not regexp.match(child.content):
continue
attr['date'] = int(time.mktime(time.strptime(child.content, format)))
Jason.
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Freevo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-devel
