Bugs item #1565765, was opened at 2006-09-26 16:21
Message generated for change (Comment added) made by duncanwebb
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1565765&group_id=46652

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: music
Group: 1.5.4
>Status: Open
Resolution: Fixed
Priority: 5
Submitted By: Duncan Webb (duncanwebb)
Assigned to: Nobody/Anonymous (nobody)
Summary: Coversearch crashes when artist or album has unicode char

Initial Comment:
Hi all,

These is an unicode error in freevo-1.5.4 coversearch
when an artist or 
album name contains none ascii characters.

audio/plugins/coversearch.py  line: 190 can be changed to:
dict_tmp = { "artist":
artist.encode('ascii','replace'), "album":
album.encode('ascii','replace') }
which stop a crash.

But I feel that there is a better fix for this, but
can't figure it out.

----------------------------------------------------------------------

>Comment By: Duncan Webb (duncanwebb)
Date: 2006-09-28 10:34

Message:
Logged In: YES 
user_id=104395

That's what I expect to happen. What happens if the reverse
patch is applied, does it find the cover or do you get a crash?

Thanks

----------------------------------------------------------------------

Comment By: John Molohan (johnmolohan)
Date: 2006-09-27 21:35

Message:
Logged In: YES 
user_id=774680

I tried this on a directory called sigur rós and get no
traceback but an osd saying no matches found for sigur_r?s.

----------------------------------------------------------------------

Comment By: Duncan Webb (duncanwebb)
Date: 2006-09-26 16:21

Message:
Logged In: YES 
user_id=104395

Fix applied

----------------------------------------------------------------------

Comment By: Duncan Webb (duncanwebb)
Date: 2006-09-26 16:21

Message:
Logged In: YES 
user_id=104395

Patch applied to branches/rel-1-5/freevo at:
svn://svn.freevo.org/freevo/branches/rel-1-5/freevo

Please test

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1565765&group_id=46652

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freevo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to