Bugs item #1568113, was opened at 2006-09-30 02:04
Message generated for change (Comment added) made by duncanwebb
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1568113&group_id=46652
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Pierre Ossman (dr7eus)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix calls to lirc
Initial Comment:
The current handling of lirc codes is a bit broken and
causes freevo to interpret unknown buttons (i.e.
unmapped for freevo) as a repeat of the previous. This
mistake was probably made since a button that isn't
configured to repeat will generate these unmapped
events on each resend. The proper way is to add "repeat
= #" in lircrc.
Patch to fix the code:
Index: src/rc.py
===================================================================
--- src/rc.py (revision 8277)
+++ src/rc.py (working copy)
@@ -180,7 +180,6 @@
self.nextcode = pylirc.nextcode
- self.previous_returned_code = None
self.previous_code = None;
self.repeat_count = 0
self.firstkeystroke = 0.0
@@ -224,13 +223,9 @@
list = self.nextcode()
if list == []:
- # It's a repeat, the flag is 0
- list = self.previous_returned_code
- result = list
+ list = None
- elif list != None:
- # It's a new code (i.e. IR key was
released), the flag is 1
- self.previous_returned_code = list
+ if list != None:
result = list
self.previous_code = result
----------------------------------------------------------------------
>Comment By: Duncan Webb (duncanwebb)
Date: 2006-09-30 08:30
Message:
Logged In: YES
user_id=104395
Pierre, Please don't submit patches in line as you can see
it gets broken. Pipe the patch to a file and upload it.
Thanks.
The freevo standard is no-tabs and 4 spaces as an indent.
Tabs are a real pain.
If your unsing vi/vim then you can add this in ~/.vimrc or
/etc/vimrc:
" Settings for python programming
au BufNewFile,BufRead *.py set tabstop=4
au BufNewFile,BufRead *.py set shiftwidth=4
au BufNewFile,BufRead *.py set expandtab
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1568113&group_id=46652
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freevo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-devel
