Bugs item #1574885, was opened at 2006-10-10 15:55
Message generated for change (Comment added) made by sf-robot
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1574885&group_id=46652
Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: tv
Group: 1.x svn
>Status: Closed
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Richard van Paasen (rvpaasen)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fixed ivtv_xine_tv plugin
Initial Comment:
I have modified the ivtv_xine_tv plugin so that it can
be used with directfb and x11. The 6-9 seconds delay
after stopping TV has been removed; the tvguide is
shown almost immediately.
Please test if this solution works on directfb because
I have no setup available to do so.
File attached ...
Richard.
----------------------------------------------------------------------
>Comment By: SourceForge Robot (sf-robot)
Date: 2006-10-26 19:20
Message:
Logged In: YES
user_id=1312539
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).
----------------------------------------------------------------------
Comment By: Duncan Webb (duncanwebb)
Date: 2006-10-12 14:31
Message:
Logged In: YES
user_id=104395
Fixed in r8356
See also bug #1568856
----------------------------------------------------------------------
Comment By: John Molohan (johnmolohan)
Date: 2006-10-11 11:37
Message:
Logged In: YES
user_id=774680
Hi Richard,
Calling kill on xine works perfectly display returns to
freevo. I've got people over for the football now so I'll
have to wait to test the sleep.
I'll probably keep the rest of the updates on the mailing
list until we get somewhere.
John
----------------------------------------------------------------------
Comment By: Richard van Paasen (rvpaasen)
Date: 2006-10-11 10:28
Message:
Logged In: YES
user_id=182311
Just to test, what happens if you:
- add a sleep of 10 seconds in the stop() method of XineThread?
- kill xine from the command line?
Does freevo still crash then?
----------------------------------------------------------------------
Comment By: Richard van Paasen (rvpaasen)
Date: 2006-10-11 10:18
Message:
Logged In: YES
user_id=182311
ok, we cross-posted. forget my comment.
----------------------------------------------------------------------
Comment By: Richard van Paasen (rvpaasen)
Date: 2006-10-11 10:15
Message:
Logged In: YES
user_id=182311
So you do now have the following line in the output of
freevo?: ivtv_xine_tv.py (492): KILLING xine
The problem is probably a timeing issue. Xine is controlled
using an extra thread in ivtv_xine_tv. Could you test by
replacing the following:
if config.CONF.display in ('dfbmga', 'directfb',
'fbdev'):
self.fbxine = True
else:
self.fbxine = False
by just:
self.fbxine = True
on line 413-416 in ivtv_xine_tv.py? Then run again wih
debugging enabled and see what method (stopping or killing)
the plugin reports.
----------------------------------------------------------------------
Comment By: John Molohan (johnmolohan)
Date: 2006-10-11 10:08
Message:
Logged In: YES
user_id=774680
I manually changed fbxine to be True and now see the right
method being used but still get the same traceback.
ivtv_xine_tv.py (124): 1160586512.29: tv app got STOP event
ivtv_xine_tv.py (450): waiting for xine to end...
ivtv_xine_tv.py (486): killing xine
childapp.py (217): childapp: killing pid 10020 signal 9
childapp.py (223): childapp: Before wait(10020)
ivtv_xine_tv.py (450): waiting for xine to end...
childapp.py (320): stdout: No data, stopping (pid 9995)!
childapp.py (320): stderr: No data, stopping (pid 9995)!
childapp.py (238): childapp: After wait()
ivtv_xine_tv.py (500): XineThread: Stopped
ivtv_xine_tv.py (119): stopped tv app
main.py (295): handling event PLAY_END
tvguide.py (121): TVGUIDE EVENT is PLAY_END
tvguide.py (107): update schedule
screen.py (136): show, force update
Traceback (most recent call last):
----------------------------------------------------------------------
Comment By: John Molohan (johnmolohan)
Date: 2006-10-11 10:02
Message:
Logged In: YES
user_id=774680
I've added print 'CONF.disply is:%s' % config.CONF.display
and get CONF.disply is:dfbmga in the startup output so it's
picking it up alright.
Thing is that if I just play a video from the hard drive it
plays and stops fine so I guess that xine.py's stop method
is the one to reference?
One other thing to note. If I set OSD_STOP_WHEN_PLAYING = 0
then it no longer crashes, the xine process does get killed
but all I see is a frozen frame of the tv channel I was
watching, the freevo interface never returns although it is
responsive and I can navigate (blindly) using my remote.
That setting is there because of an issue with certain
output devices, I don't know anything more about it just
thought I'd pass on the info.
----------------------------------------------------------------------
Comment By: Richard van Paasen (rvpaasen)
Date: 2006-10-11 09:58
Message:
Logged In: YES
user_id=182311
Note, from your traceback I see that the wrong method (the
x11 method) is used in your directfb setup:
main.py (295): handling event STOP
ivtv_xine_tv.py (124): 1160573672.22: tv app got STOP event
ivtv_xine_tv.py (119): stopped tv app
main.py (295): handling event PLAY_END
tvguide.py (121): TVGUIDE EVENT is PLAY_END
tvguide.py (107): update schedule
ivtv_xine_tv.py (492): stoppping xine
The last line must be 'killing xine' for you. CONF.display
is the key here so either your freevo.conf is setup wrong or
I forgot to add a display setting in the ivtv_xine_tv plugin.
----------------------------------------------------------------------
Comment By: Richard van Paasen (rvpaasen)
Date: 2006-10-11 09:38
Message:
Logged In: YES
user_id=182311
Can you post your freevo.conf? The plugin checks
CONF.display to decide what action to take. It only uses the
different method for shutting down xine if display is set to
one of 'dfbmga', 'directfb', 'fbdev'.
----------------------------------------------------------------------
Comment By: John Molohan (johnmolohan)
Date: 2006-10-11 06:51
Message:
Logged In: YES
user_id=774680
Hi guys,
Thanks for trying to find a solution for this. I'm afraid
that I still get a crash. I can't test the old plugin
because of the multituner support changes. Richard do you
have a copy of the old plugin or should I post it to the
devel list (I can't add another file here)?
main.py (295): handling event STOP
ivtv_xine_tv.py (124): 1160573672.22: tv app got STOP event
ivtv_xine_tv.py (119): stopped tv app
main.py (295): handling event PLAY_END
tvguide.py (121): TVGUIDE EVENT is PLAY_END
tvguide.py (107): update schedule
ivtv_xine_tv.py (492): stoppping xine
rc.py (447): unregister callback: <bound method XineApp.poll
of <tv.plugins.ivtv_xine_tv.XineApp instance at 0xaf5c08cc>>
rc.py (451): unregister shutdown callback: <bound method
XineApp.stop of <tv.plugins.ivtv_xine_tv.XineApp instance at
0xaf5c08cc>>
childapp.py (418): sending exit command to app
screen.py (136): show, force update
Traceback (most recent call last):
File "/home/media/freevo-1.5/src/main.py", line 321, in
eventhandler
app.eventhandler(event)
File "/home/media/freevo-1.5/src/menu.py", line 425, in
eventhandler
if not isinstance(menu, Menu) and menu.eventhandler(event):
File "/home/media/freevo-1.5/src/tv/tvguide.py", line 214,
in eventhandler
self.show()
File "/home/media/freevo-1.5/src/tv/tvguide.py", line 225,
in show
self.refresh()
File "/home/media/freevo-1.5/src/tv/tvguide.py", line 238,
in refresh
self.menuw.refresh()
File "/home/media/freevo-1.5/src/menu.py", line 331, in
refresh
return skin.draw(menu.type, menu)
File "/home/media/freevo-1.5/src/skins/main/main.py", line
538, in draw
osd.update([self.screen.show(self.force_redraw)])
File "/home/media/freevo-1.5/src/skins/main/screen.py",
line 207, in show
osd.screenblit(layer, (u[0], u[1]), (u[0], u[1], u[2] -
u[0], u[3] - u[1]))
File "/home/media/freevo-1.5/src/osd.py", line 800, in
screenblit
ret = self.screen.blit(source, destpos, sourcerect)
error: display Surface quit
GUIObject.py (261): GUIObject::draw
<gui.ConfirmBox.ConfirmBox instance at 0xaf5c056c>
Window.py (144): Window::_draw <gui.ConfirmBox.ConfirmBox
instance at 0xaf5c056c>
Crash!
childapp.py (320): stdout: No data, stopping (pid 8530)!
childapp.py (320): stderr: No data, stopping (pid 8530)!
childapp.py (209): done the easy way
---------------------- DirectFB v0.9.25
---------------------
(c) 2000-2002 convergence integrated media GmbH
(c) 2002-2004 convergence GmbH
-----------------------------------------------------------
(*) DirectFB/Core: Single Application Core. (2006-05-05 18:21)
(*) Direct/Memcpy: Using MMXEXT optimized memcpy()
(*) DirectFB/Core: doing sync()...
(*) Direct/Thread: Running 'VT Switcher' (CRITICAL, 8589)...
(*) Direct/Thread: Running 'PS/2 Input' (INPUT, 8590)...
(*) DirectFB/Input: IMPS/2 Mouse 1.0 (Convergence GmbH)
(*) Direct/Thread: Running 'LiRC Input' (INPUT, 8591)...
(*) DirectFB/Input: LIRC Device 0.2 (convergence integrated
media GmbH)
(*) Direct/Thread: Running 'Linux Input' (INPUT, 8592)...
(*) DirectFB/Input: DELL DELL USB Keyboard (1) 0.1
(convergence integrated media GmbH)
(*) Direct/Thread: Running 'Linux Input' (INPUT, 8593)...
(*) DirectFB/Input: DELL DELL USB Keyboard (2) 0.1
(convergence integrated media GmbH)
(*) Direct/Thread: Running 'Linux Input' (INPUT, 8594)...
(*) DirectFB/Input: PC Speaker (3) 0.1 (convergence
integrated media GmbH)
(*) Direct/Thread: Running 'Keyboard Input' (INPUT, 8595)...
(*) DirectFB/Input: Keyboard 0.9 (convergence integrated
media GmbH)
(*) DirectFB/Genefx: MMX detected and enabled
(*) DirectFB/Graphics: Matrox G450 0.7 (directfb.org)
(*) DirectFB/Core/WM: Default 0.2 (Convergence GmbH)
SDL DirectFB_SetVideoMode: [EMAIL PROTECTED], flags: 0x00000000
ivtv_xine_tv.py (500): XineThread: Stopped
osd.py (220): Loading font
"/home/media/freevo-1.5/share/fonts/Vera.ttf"
Traceback (most recent call last):
File "/home/media/freevo-1.5/src/main.py", line 498, in ?
MainTread().run()
File "/home/media/freevo-1.5/src/main.py", line 358, in run
self.eventhandler(rc.get_event(True))
File "/home/media/freevo-1.5/src/main.py", line 346, in
eventhandler
pop.show()
File "/home/media/freevo-1.5/src/gui/GUIObject.py", line
199, in show
self.draw()
File "/home/media/freevo-1.5/src/gui/GUIObject.py", line
267, in draw
self._draw()
File "/home/media/freevo-1.5/src/gui/Window.py", line 156,
in _draw
self.surface =
self.osd.Surface(self.get_size()).convert_alpha()
error: cannot convert without pygame.display initialized
plugin.py (365): shutdown plugin
rom_drives.py (140): stopping Identify_Thread
plugin.py (365): shutdown plugin
plugin.py (365): shutdown plugin
rc.py (473): shutting down <bound method autostart.shutdown
of <plugins.rom_drives.autostart instance at 0xb0c9536c>>
----------------------------------------------------------------------
Comment By: Duncan Webb (duncanwebb)
Date: 2006-10-11 05:37
Message:
Logged In: YES
user_id=104395
The patch has been applied in r8346.
Richard, many thanks
Hopefully John will give this a test on his system.
What I didn't understand is why you couldn't attach the
patch to the original bug, is Upload and Attach a File not
available for non-admins? It should be at the very bottom of
the bug report.
----------------------------------------------------------------------
Comment By: Richard van Paasen (rvpaasen)
Date: 2006-10-10 16:19
Message:
Logged In: YES
user_id=182311
Note: forgot to merge changes in the latest release.
Uploaded a new file.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1574885&group_id=46652
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Freevo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-devel
