Bugs item #1591170, was opened at 2006-11-06 07:54
Message generated for change (Settings changed) made by dr7eus
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1591170&group_id=46652

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: players
Group: 1.6.0
>Status: Open
Resolution: Fixed
Priority: 5
Private: No
Submitted By: Pierre Ossman (dr7eus)
Assigned to: Nobody/Anonymous (nobody)
Summary: Autocrop needs more samples

Initial Comment:
The autocrop feature sometimes gets things very, very
wrong. The problem is that it looks at such a short
part of a movie, so it's easily fooled.

Simply increasing the number of frames is not a viable
solution as the scene in the movie is probably similar
in that problem area. What we need is samples from more
locations in the file.

Either we start mplayer multiple times, or we get it to
seek. I'm not familiar with how to control mplayer via
commands, so I do not know how to do the latter. But
someone else perhaps has this know-how :)

----------------------------------------------------------------------

>Comment By: Pierre Ossman (dr7eus)
Date: 2006-11-19 14:34

Message:
Logged In: YES 
user_id=687084
Originator: YES

New implementation of the autocrop. It uses the slave protocol to do the
magic.

This version will check four locations and ten frames at each seek.

----------------------------------------------------------------------

Comment By: Duncan Webb (duncanwebb)
Date: 2006-11-07 19:06

Message:
Logged In: YES 
user_id=104395

Applied the fix using twice the TV_RECORD_PADDING_PRE in
rel-1-6 at r8552. 

Using -sstep 60 would be too slow at play time. But this is
the approach that the encoding server uses.


----------------------------------------------------------------------

Comment By: Pierre Ossman (dr7eus)
Date: 2006-11-06 14:37

Message:
Logged In: YES 
user_id=687084

CPU and/or disk usage should go through the roof if it was
playing at maximum speed, but it isn't. So I'm afraid that's
insufficient. If you add stuff like '-fps 1000', things go
faster. But a "go as fast as you possibly can" would be nice.

----------------------------------------------------------------------

Comment By: Duncan Webb (duncanwebb)
Date: 2006-11-06 14:23

Message:
Logged In: YES 
user_id=104395

AFAIK -vo null -ao null

----------------------------------------------------------------------

Comment By: Pierre Ossman (dr7eus)
Date: 2006-11-06 14:12

Message:
Logged In: YES 
user_id=687084

Ahh.... Terribly sorry, I missed that part of your comment.
I'll do some tests tonight and figure something out. Do you
know of any flags to completely disable time sync? Running
at real time when we're scanning the file is just a waste of
the user's time.

----------------------------------------------------------------------

Comment By: Duncan Webb (duncanwebb)
Date: 2006-11-06 14:08

Message:
Logged In: YES 
user_id=104395

Another way is to use:
mplayer -vo null -ao null -ss 180 -sstep 60 -vf cropdetect
/path/to/file but it's a lot slower.

----------------------------------------------------------------------

Comment By: Pierre Ossman (dr7eus)
Date: 2006-11-06 13:41

Message:
Logged In: YES 
user_id=687084

That won't solve the problem. The issue is that with such a
short sample (20 frames), we have a high risk of getting
incorrect crop dimensions (because of a dark scene). What we
need is to increase the number of samples and to do that
efficiently we would need to seek.

----------------------------------------------------------------------

Comment By: Duncan Webb (duncanwebb)
Date: 2006-11-06 13:04

Message:
Logged In: YES 
user_id=104395

A bit tricky if an ad break is scanned as they ususally have
different crop, some shows start and then almost immediately
have an ad break.

One solution is for the -ss command to be
TV_RECORD_PADDING_PRE * 2

Here is an untested patch, you could test it :-)

-ss <time> (also see -sb)
Seek to given time position.
EXAMPLE:
 -ss 56
  Seeks to 56 seconds.
 -ss 01:10:00
  Seeks to 1 hour 10 min.

Also:
 -sstep <sec>
   Skip  <sec> seconds after every frame.  The normal
framerate of the movie is kept, so playback is accelerated.
 Since MPlayer can only seek to the next keyframe this may
be inexact.

A bit of trial and error here, but there may not be an ideal
solution.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1591170&group_id=46652

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freevo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to