Thanks. I'm not sure why I couldn't attach. The button just wasn't there.
Duncan Webb wrote:
> Ryan Roth wrote:
>
>> I could not attach these on the sf.net page for some reason.
>>
>
> But anyway thanks for the patch it looks good, I'll add but call the
> config variable WEBSERVER_HTDOCS. Wonder why I didn't change WWW_USERS
> at the time.
>
> I'm curious why couldn't you attach a patch, could it be because your
> not the original owner of the report or something else?
>
> Nothing to do with your changes, I don't like file_cache_link being a
> subdirectory of htdocs, it should be in /var/cache/freevo.
>
> BTW The sender may miss the patches if you sent the message to the
> developers list. It may be better using the users list when replying to
> a bug report, as it may have most of the developers too.
>
> Duncan
>
>
>> ------------------------------------------------------------------------
>>
>> Index: fileinfo.rpy
>> ===================================================================
>> --- fileinfo.rpy (revision 8748)
>> +++ fileinfo.rpy (working copy)
>> @@ -112,7 +112,10 @@
>> return String( fv.res )
>>
>> def create_file_link(self, file):
>> - current_path = "%s/share/freevo/htdocs/" % sys.prefix
>> + if not hasattr(config, 'WWW_PATH'):
>> + current_path = "%s/share/freevo/htdocs/" % sys.prefix
>> + else:
>> + current_path = config.WWW_PATH
>> file_cache_link = "file_cache/" + file.replace("/", "_")
>> if not os.path.exists("%s/share/freevo/htdocs/" % sys.prefix +
>> file_cache_link):
>> os.symlink(file , current_path + file_cache_link)
>>
>>
>> ------------------------------------------------------------------------
>>
>> Index: library.rpy
>> ===================================================================
>> --- library.rpy (revision 8748)
>> +++ library.rpy (working copy)
>> @@ -497,7 +497,10 @@
>> return String( fv.res )
>>
>> def get_images(self, myfile):
>> - current_path = "%s/share/freevo/htdocs/" % sys.prefix
>> + if not hasattr(config, 'WWW_PATH'):
>> + current_path = "%s/share/freevo/htdocs/" % sys.prefix
>> + else:
>> + current_path = config.WWW_PATH
>> image_cache_link = "image_cache/" + myfile.replace("/", "_")
>> if not os.path.exists("%s/share/freevo/htdocs/" % sys.prefix +
>> image_cache_link):
>> os.symlink(myfile , current_path + image_cache_link)
>>
>>
>> ------------------------------------------------------------------------
>>
>> -------------------------------------------------------------------------
>> Take Surveys. Earn Cash. Influence the Future of IT
>> Join SourceForge.net's Techsay panel and you'll get the chance to share your
>> opinions on IT & business topics through brief surveys - and earn cash
>> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Freevo-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/freevo-devel
>>
>
>
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Freevo-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/freevo-devel
>
>
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freevo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-devel
