Bugs item #1621220, was opened at 2006-12-23 11:53 Message generated for change (Comment added) made by duncanwebb You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1621220&group_id=46652
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: video Group: 1.x svn >Status: Pending >Resolution: Accepted Priority: 5 Private: No Submitted By: Gorka Olaizola (gorka) Assigned to: Nobody/Anonymous (nobody) Summary: Sum length of subitems and manual aspect Initial Comment: The attached patch adds the length of the subitems to the runtime information and adds a manual calculated aspect ratio if the file has no embedded aspect ratio. It also corrects the removal of the line x.files = FileInformation() that I thought it was not important but without it Freevo crashes when showing the submenu of an item with subitems. ---------------------------------------------------------------------- >Comment By: Duncan Webb (duncanwebb) Date: 2006-12-23 13:43 Message: Logged In: YES user_id=104395 Originator: NO Nice patch, thanks The patch has been applied to rel-1 at r8794, with some minor modifications. You don't mind if I make some comments? if s.info['runtime'] and s.info['runtime'] != 'None': can be shortened to: if s.info['runtime']: because, while None is not the same as 0 (zero) they both evaluate to False. The if isinstance(): calls are simplier when they are try: except: blocks. tehe, unusually had spotted the x.files = [] error, should have mentioned it. You may get a conflict when svn update is run. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=446895&aid=1621220&group_id=46652 ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Freevo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freevo-devel
