On Sat, 2006-12-23 at 19:12 +0100, Duncan Webb wrote: > Adding checks on the buffer length has corrected this problem, now kill > bill doesn't kill kaa.
Sounds ok, but doesn't the fact that this died where it did indicate either a corrupt mkv or some other bug in the parser? If it's a bug elsewhere, adding a length check is just masking the symptom, not curing the problem. I'm not saying we should rollback your commit -- it helps improve robustness in the corrupt mkv case -- but if this is a parser bug I'd rather see it fixed. :) > It would be nice to add the aid and sid values, the first audio and > subtitle tracks start at 0. Very similar to mpeg files which start at > 128 (except DTS) This sounds easy enough. Will do it when I return home from holidays. Cheers, Jason. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Freevo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freevo-devel
