Jason Tackaberry wrote:
> Modified: trunk/base/src/distribution/core.py
> ==============================================================================
> --- trunk/base/src/distribution/core.py (original)
> +++ trunk/base/src/distribution/core.py Sat Dec 30 00:29:03 2006
> @@ -392,16 +392,11 @@
> if not os.path.isfile('%s.ebuild' % name):
> print 'No ebuild template provided'
> return 0
> - fd = open('%s.ebuild' % name)
> - edata = fd.readlines()
> - fd.close()
> + edata = open('%s.ebuild' % name).read()
That leaves the fd open. OK, it is not a big deal because we are
talking about setup.py here, but it is still ugly. Or do we close when
we loose the reference?
Dischi
--
In California they don't throw their garbage away -- they make it into
television shows.
-- Woody Allen, "Annie Hall"
pgpxXWjZ4TB3I.pgp
Description: PGP signature
------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________ Freevo-devel mailing list Freevo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-devel
