Hi Dischi,
On Sunday 11 February 2007 12:31, Dirk Meyer wrote:
> naudefj wrote:
> > Hi Jason,
> >
> >> Bitrate calculations in many of the parsers are incorrect, and in others
> >> are completely and unfathomably out to lunch.
> >
> > I'm referring to a very specific problem that IMHO is release critical to
> > Freevo 1.7.
>
> Why is it critical? Is there any part of Freevo using that?
It's being used in 1.7. Refer to F#1580712: Replaced mmpython with kaa.base
and kaa.metadata.
> > The problem can easily be fixed with a simple patch like this:
> >
> > Index: kaa/metadata/src/audio/ogg.py
> > ===================================================================
> > --- kaa/metadata/src/audio/ogg.py (revision 2455)
> > +++ kaa/metadata/src/audio/ogg.py (working copy)
> > @@ -69,6 +69,7 @@
> > self.version, self.channels, self.samplerate, bitrate_max, \
> > self.bitrate, bitrate_min, blocksize, \
> > framing = struct.unpack('<IBIiiiBB',info[:23])
> > + self.bitrate = self.bitrate / 1000;
> > # INFO Header, read Oggs and skip 10 bytes
> > h = file.read(4+10+13)
> > if h[:4] == 'OggS':
> >
> > However, this is not the best way of solving the problem. I would really
> > appreciate if you can help with a proper fix.
>
> No, it is the proper way to fix this. In svn now. But other parser may
> have the same bug.
>
Great. Thank you very much!
Best regards.
Frank
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Freevo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-devel
