Jason Tackaberry wrote:
> Dirk Meyer wrote:
>> There was a reason why the flac parser was at the end because it had
>> some false positive detections. We need some extra attribute about the
>> rating of a parser to sort them when checking all possible parser.
>>
>
> If a parser has a problem with false positives (like the mp3 parser
> did), then we should fix the parser to not be so trigger happy (like I
> did with the mp3 parser) rather than kludge things by fiddling with the
> order.
>
> But in the meantime I will restore the order of register calls.
What about more/less general parsers? svn kaa.metadata doesn't seem to
recognize video dvds because of this (cd/unknown matches first). I fixed it
with the attached (feel free to dump if this is not the proper fix ;-)
Cheers,
A/
Index: metadata/src/__init__.py
===================================================================
--- metadata/src/__init__.py (revision 2600)
+++ metadata/src/__init__.py (working copy)
@@ -62,11 +62,11 @@
# Disc parsers
register('audio/cd', EXTENSION_DEVICE, 'disc.audio')
-register('cd/unknown', EXTENSION_DEVICE, 'disc.data')
register('video/dvd', EXTENSION_DEVICE, 'disc.dvd')
register('video/dvd', EXTENSION_DIRECTORY, 'disc.dvd')
register('video/dvd', ('iso',), 'disc.dvd')
register('video/vcd', EXTENSION_DEVICE, 'disc.vcd')
+register('cd/unknown', EXTENSION_DEVICE, 'disc.data')
# Image parsers
register('image/bmp', ('bmp', ), 'image.bmp')
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Freevo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-devel
