Hi,

I did a quick look over the patch. Basicly I have no time to work on
it and never put too much toughts into this. This means if you think
it is ok I will add this patch.

But I have some questions:

Tanja wrote:
> -        for t in times:
> -            m = _time_re.match(t).groups()
> -            start = int(m[0])*100 + int(m[1])
> -            stop  = int(m[2])*100 + int(m[3])
> -            self.times.append((start, stop))
> +        self.times     = times
[...]
> -            times.add_child('start', '%02d:%02d-%02d:%02d' % \
> -                            (t[0] / 100, t[0] % 100, t[1] / 100, t[1] % 100))
> +            times.add_child('start', t)

Is there a reason why you store the time as int and not in a human
readable form? Or did I miss something? IMHO it is better to have a
human readable form in the fxd file.

>          # fetch epg data from InProgress object
>          query_data = query_data()
>          for prg in query_data:
> -            items.append(ProgramItem(prg, self))
> +            if prg.stop > time.time():
> +                # only add this to the list, if it has not already finished
> +                items.append(ProgramItem(prg, self))

We need a better way to do the query. The query should return a)
stop > time.time() and b) sorted by time.

@Tack: how can we add this to kaa.epg?

> -DAY_NAMES = (_('Sun'), _('Mon'), _('Tue'), _('Wed'), _('Thu'), _('Fri'), 
> _('Sat'))
> +DAY_NAMES = [_('Sun'), _('Mon'), _('Tue'), _('Wed'), _('Thu'), _('Fri'), 
> _('Sat')]

Any reason for this?




Dischi

-- 
/dev/brain0 was not cleanly unmounted, check forced:
e2fsck 1.14, 9-Jan-1999 for EXT2 FS 0.5b, 95/08/09
e2fsck: Attempt to read block from filesystem resulted in short read 
while trying to open /dev/brain0
Could this be a zero-length partition?

Attachment: pgpQMjO4e8mCX.pgp
Description: PGP signature

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Freevo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to