Hi again,

just a short update.

Tanja schrieb:
> Hallo Adam,
> 
> [EMAIL PROTECTED] schrieb:
>> Tanya, I see that you've updated the RecordingsManager plugin to use
>> directly (via subclassing) VideoItem.
>>
>> I had avoided doing this as I was trying to keep the user interface as
>> simple as possible with out cluttering it and keeping the most important
>> actions on the button bar (ie Delete/(Un)Mark as Watched/(Un)Mark to
>> Keep). (My Wife really doesn't want to know that she can 'Play with
>> alternative player' she just wants it to work)
> 
> My idea was to have all actions that I usually have for recordings
> in the usual order which moves 'Delete' to the end of the list.
> Moreover I had the idea that this will enable all video plugins (hopefully).
> 
>> Is there any way we can rearrange the actions so that we keep the same
>> order of things.
> 
> I have two ideas in mind,how to make it more wife friendly ;-)
> 
> 1.) We can put the actions in an different and put the two mark actions
> behind 'Play' and 'Full description', then you only have to open the submenu
> for delete, which is still the last in the list.
> 
> 2.) I saw you define a blue_action somewhere. Is that a possiblity to
> define actions for the buttons? I did not investigate that further,
> but maybe that is a more clean solution?
> 

Solution 1 is easier:
        
    def actions(self):
         """
         return the default action
         """
         actions = self.video_item.actions()
         items = actions[0:2]
         items.append((self.mark_to_keep, self.keep and _('Unmark to Keep') or 
_('Mark to Keep')))
         items.append((self.mark_as_watched, self.watched and _('Unmark as 
Watched') or _('Mark as 
watched')))
         items = items + actions[2:]
         return items

But we can also use the colour_actions to define:
RED = Full description
GREEN = (Un)Mark to Keep
YELLOW = (Un)Mark as Watched
BLUE = Delete
Since you can always reach more options by using the SUBMENU key, it seems ok 
to remove the more 
options option from the buttonbar. But it would not be consistent with other 
part of freevo,
which I find a little ugly.


>> Having said all that I can see why you did it, hopefully we get screen
>> captures in the recording manager now?
> 
> I just tested, it is not working right now. I will put it on my TODO list.

Forget this. More tests show that it seems to be working.


> There is also another bug: when you choose 'delete all', freevo crashes!
> I hope your wife did not try to do that yet. My husband tried it a few minutes
> ago and I have to work on it first, as you may understand :-(
> 

solved: [ freevo-Bugs-1779806 ]

> And there is also a crash in the recordserver after updating the schedule,
> when AllowDuplicates is enabled, which costs him some of his favorite 
> programs :-(
> 

also solved: [ freevo-Bugs-1779815 ] (hopefully)



But I am still thinking, that maybe you were right not to subclass 
RecordingsItem.
There are still some issues, for example it seems that the watched item is not 
updated correctly.
I will continue to work on it...

Regards
Tanja

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Freevo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to