Hi James, James Trietsch schrieb: > Tanja, thanks for the reply. I'm always nervous in times like this. You guys > have been hammering on Freevo for a > long time and here I'm just stepping up to the plate. But we all have to > start somewhere, right? Actually I am not that far away from you in this as you might think, I also just started to play around with the code and to learn more of python. Thus I am glad to share my insights with you!
> I should have mentioned I'm using version 1.7.3, but I know if I'm serious > about contributing, > I should download the SVN to avoid problems like this. Would certainly be better, as there is a lot of developing going on these days. You should probably set up a stable copy of freevo for everyday life and one svn copy for developing. If you have some patches, they have to be against the current svn version anyway, otherwise Duncan would not accept them. And I am sure, sooner or later you will want to send a patch, as I said there is enough work to be done in freevo :-) > Tonight, I hit upon the exact idea you say is already implemented, that > RecordedProgramItem should inherit from VideoItem. When I tried it, though, > it caused a whole lot of other problems (mainly in set_url). If you say this > is all sorted out and cool after rev 9842, Good to hear, that that idea is not totally stupid, as I was the one who implemented it that way first. Please try the current svn version. But I cannot promise that everything is sorted out. But that gives you some change to improve the code. So I am looking forward to see your suggestions. > then I'll make sure to check it out (literally?) tomorrow. Who knows, maybe > other things I've fixed in 1.7.3 have been fixed already in the SVN copy. Possible, and maybe other things are broken ;-) > If I put in a print statement for debugging, that will just drop things to > the console? That's fine for quick-and-dirty output when chasing bugs. Yes, that helps a lot. Maybe that is not the professional way to do it, but it is effective ;-) > Alright, I just downloaded the SVN and it looks like I had rev 9763 of RM > before. I'll definitely take a look at the latest one (10147) and let you > know how > things turn out. I'm putting this on pause, since the majority of my problems > might be solved. Hopefully! > Thank you for detailing the process on how items are set up. I think I was > getting confused because in videoitem.py it does a player check > in actions to decide what submenu playback items should appear, and then > there is a 'just in case' clause in play where it does the same check > if self.possible_player is still empty and sets things up. Right, that code duplication was ugly and should now be resolved. The player check is now only in set_url() and that is called in __ini__. But there is always the danger, that some other part of freevo is expecting the player check in actions or in play. One must be very carefull now, that the check is done with the right input video data, because otherwise it gives strange results. I remember there have been a problem, because somewhere the VideoItem is first created with a empty url and then the url is set afterwards without using set_url() and then of course no player was available for this VideoItem... > I'll be back! I'm sure of it. Great! We are waiting for your patches ;-) Tanja ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Freevo-devel mailing list Freevo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-devel
