Jason Tackaberry wrote: > + def __init__(self, address, auth_secret = '', buffer_size = None): > + sock = kaa.Socket(buffer_size) > + sock.buffer_size = buffer_size > + # FIXME: we block on connect for now; Channel.rpc() tests socket > + # connected and raises exception if it isn't, so if we do rpc() right > + # after connecting, it will fail. > + sock.connect(address).wait() > + Channel.__init__(self, sock, auth_secret)
That sucks very badly. IMHO wait should _never_ be used and should print a warning. Using notifier.step can cause many strange problems. On a side note: this check-in broke beacon and I guess a lot of other parts using kaa.rpc. Dischi -- Viewer discretion may be advised, but it's never really expected.
pgpCt5KwGNcN8.pgp
Description: PGP signature
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________ Freevo-devel mailing list Freevo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-devel
