On Thu, 2008-03-13 at 19:24 +0100, Duncan Webb wrote:
> Log:
> Removed except Exception code, should allow the exceptions to travel up the 
> stack
[...]
> +        inprogress = self.recordserver_rpc('findNextProgram', isrecording)
> +        if inprogress is None:
>              return None
> +        inprogress.wait()
> +        result = inprogress.get_result()
> +        _debug_('findNextProgramNow.result=%r' % (result,), 1)
> +        return result

I don't normally review or comment on freevo code, but it was impossible
not to notice that this boilerplate was repeated 17 times.  It's just
screaming to be moved into a separate function. :)



-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to