On Sun, 2008-05-25 at 19:02 +0200, Dirk Meyer wrote:
> > Log:
> > Signal.async() convenience function (see docstring)
> 
> I don't like it. It is a convenience function to wrap just one line:

It was more a matter of readability.  For me, it seemed a lot more
intuitive to me that I was performing some function _with_ a signal
(using it in an async way).

The signal-specific code in InProgressCallback should be moved into
Signal.async() which would make it more than just one line.  (I never
liked the special case of the signal code in
InProgressCallback.__init__)


> but on the downside it adds circular dependencies. 

Certainly it's not the only place where we do that.  The problem is
avoided, as with the others, of importing at invocation time rather than
import time.  I think this is fine and well understood.




-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel

Reply via email to