Jason Tackaberry wrote: > On Fri, 2008-08-08 at 13:32 +0200, Dirk Meyer wrote: >> + # We should connect weakly so that if the we're destroyed we >> + # automatically disconnect from the signal. But that doesn't >> + # work somehow and beacon stops working. So we just connect. >> + # This special case is about the be removed so we can ignore >> + # the missing disconnect. >> + func = func.connect_once >> # connect self as callback >> func(self) > > These sorts of comments like "that doesn't work somehow" make me a bit > nervous. :) Are you really not sure why it doesn't work?
Sorry for the bad comment, but no, I have no idea. The code in question is | yield kaa.InProgressCallback(self._client.signals['connect']) With the weak connect it simply does not work and I have no idea why that happens. > The idea behind the weak connect should be obvious: [...] > Let's demonstrate the problem: I understand the problem but yesterday we agreed to remove the signal support anyway. So I figured the best way is to make beacon work again and ignore that problem. It took me long enough to find it, I did not waste any more time. > It seems vastly better to connect weakly and have it disconnect when > the InProgressCallback is destroyed. And this, incidentally, is how > I'm going to do __async__ anyway, so it'd be much better if you > sorted out why this breaks beacon. :) In that case we need to figure out why. It is very simple to show, just use weak connect and start the kaa.candy beacon testcase. You will never see images because the code is stuck in query.py in the line quoted above. Maybe you can figure out why Dischi -- The voices in my head may not be real, but they have some good ideas! ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Freevo-devel mailing list Freevo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-devel
