hi,
since I installed 1.8.2 I got some crashes in recordings_manager.py,
(see attached log) that seem to happen when a file is removed
the following patch fixes it, and makes sense, since 'set's objects in
Python do not have an 'append' method but rather a 'add'
a.
2008-09-30 22:07:23,939 CRITICAL main.py (506): Crash!: 'set' object has no
attribute 'append'
Traceback (most recent call last):
File "/usr/lib/python2.5/site-packages/freevo/main.py", line 497, in <module>
kaa.main.run()
File "/usr/lib/python2.5/site-packages/kaa/notifier/main.py", line 140, in run
loop(True)
File "/usr/lib/python2.5/site-packages/kaa/notifier/main.py", line 110, in
loop
notifier.step()
File
"/usr/lib/python2.5/site-packages/kaa/notifier/pynotifier/nf_generic.py", line
185, in step
if not timer[ CALLBACK ]():
File "/usr/lib/python2.5/site-packages/kaa/notifier/timer.py", line 176, in
__call__
return super(Timer, self).__call__(*args, **kwargs)
File "/usr/lib/python2.5/site-packages/kaa/notifier/nf_wrapper.py", line 97,
in __call__
ret = super(NotifierCallback, self).__call__(*args, **kwargs)
File "/usr/lib/python2.5/site-packages/kaa/notifier/callback.py", line 168,
in __call__
result = cb(*cb_args, **cb_kwargs)
File "/usr/share/pyshared/freevo/rc.py", line 661, in poll
c[0](*c[4])
File "/usr/share/pyshared/freevo/tv/plugins/recordings_manager.py", line 832,
in poll
self.check_recordings()
File "/usr/share/pyshared/freevo/tv/plugins/recordings_manager.py", line 863,
in check_recordings
self.update_recordings()
File "/usr/share/pyshared/freevo/tv/plugins/recordings_manager.py", line 908,
in update_recordings
added_files.append(itemfile)
AttributeError: 'set' object has no attribute 'append'
--- /usr/share/pyshared/freevo/tv/plugins/recordings_manager.py.orig 2008-07-29 20:01:32.000000000 +0200
+++ /usr/share/pyshared/freevo/tv/plugins/recordings_manager.py 2008-09-30 22:17:24.000000000 +0200
@@ -905,7 +905,7 @@
# those files.
for itemfile in rpitem.files.files + [rpitem.files.fxd_file, rpitem.files.edl_file, rpitem.files.image]:
if itemfile in files:
- added_files.append(itemfile)
+ added_files.add(itemfile)
deleted = True
break
if not deleted:
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel
