-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
hi,
I dedicated some time to solve the bug 2502039 ; in doing so I
encountered many points in the code that IMHO are bugs, or buglets; I am
going to post a list of patches, trying to explain as clearly as possible.
The first post re: umount_all . This is an option in creating menus,
that has no effect whatsoever. I propose (see patch) to simply
obliterate it.
a.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkltA5YACgkQ9B/tjjP8QKT5PgCeL4xRpV9hXm9+RQKsrEAYHM2M
2ZIAoIRQ+Bzg1vd7MGVhK2m1IRIu+As0
=nNW7
-----END PGP SIGNATURE-----
Index: menu.py
===================================================================
--- menu.py (revisione 11242)
+++ menu.py (copia locale)
@@ -117,7 +117,7 @@
a Menu with Items for the MenuWidget
"""
@benchmark(benchmarking, benchmarkcall)
- def __init__(self, heading, choices, fxd_file=None, umount_all=0, reload_func=None, item_types=None,
+ def __init__(self, heading, choices, fxd_file=None, reload_func=None, item_types=None,
force_skin_layout=-1):
self.heading = heading
@@ -129,7 +129,6 @@
self.page_start = 0
self.previous_page_start = []
self.previous_page_start.append(0)
- self.umount_all = umount_all # umount all ROM drives on display?
self.skin_settings = None
if fxd_file:
self.skin_settings = skin.load(fxd_file)
@@ -443,10 +442,6 @@
return False
return menu.refresh()
- #DJW: why do we do this?
- #if self.menustack[-1].umount_all == 1:
- # util.umount_all()
-
if reload:
if menu.reload_func:
reload = menu.reload_func()
Index: video/videoitem.py
===================================================================
--- video/videoitem.py (revisione 11242)
+++ video/videoitem.py (copia locale)
@@ -771,7 +771,7 @@
items.append(i)
- moviemenu = menu.Menu(self.name, items, umount_all=1, fxd_file=self.skin_fxd)
+ moviemenu = menu.Menu(self.name, items, fxd_file=self.skin_fxd)
moviemenu.item_types = 'video'
self.menuw.pushmenu(moviemenu)
Index: main.py
===================================================================
--- main.py (revisione 11242)
+++ main.py (copia locale)
@@ -177,7 +177,7 @@
for i in items:
i.is_mainmenu_item = True
- mainmenu = menu.Menu(_('Freevo Main Menu'), items, item_types='main', umount_all = 1)
+ mainmenu = menu.Menu(_('Freevo Main Menu'), items, item_types='main')
menuw.pushmenu(mainmenu)
osd.add_app(menuw)
Index: plugins/mediamenu.py
===================================================================
--- plugins/mediamenu.py (revisione 11242)
+++ plugins/mediamenu.py (copia locale)
@@ -221,7 +221,7 @@
item_menu = menu.Menu(menutitle, items,
item_types = '%s main menu' % self.display_type,
- umount_all=1, reload_func = self.reload)
+ reload_func = self.reload)
item_menu.skin_force_text_view = force_text_view
self.menuw = menuw
menuw.pushmenu(item_menu)
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Freevo-devel mailing list
Freevo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freevo-devel
