On Sat, 2010-11-06 at 16:32 -0700, James Trietsch wrote: > Thanks Dischi and Evan for the advice. I'm gonna start packing up the 'easy' > things that don't interfere with each other. I'm not sure any of my code > patches-on-patches, but I've seen at least one instance where two patches add > on > code to the same file in succession. That is, the code looks like: > > Original Code - Patch A - Patch B - Original Code > > Now if I just do the diff out of SVN and break it up by hand, I feel like > there > will be a problem when the second patch (be it A or B) is applied, because it > would be expecting the original code on either end of the modifications but > is > going to find the patched code instead. I don't know for sure, I haven't used > patch that extensively. I'll see if I can test it myself, but it seems like a > no-win situation unless I pick a specific order. On the other hand, there's > really no harm in making it one big patch... the extra code will lie dormant > and > not cause problems (at least in this example), but it's extra code that > wouldn't > be used unless the other patches for that function were used.
That shouldn't be a problem as I'll try and commit all the changes in a couple of days after you've submitted the patches. > Sorry, kinda went stream-of-consciousness there. I'll figure it out one way > or > another. > > Finally, since it's been a few years since I've submitted anything, so is > there > anything I need to remember besides just submitting to the bug tracker? > Special > titles, or designations or something like that? Nope, just a good title and description is all that is required. > Thanks again for all your patience and help. The Freevo has been a joy to use > and it's been my pleasure to be making fixes and tweaks and additions to it. > Heck, in this latest round, it helped me finally wrap my head around OOP and > I > dipped my toes quite successfully into spawning and controlling external > programs. I feel like a real programmer! ^_^ > > James Cheers Adam ------------------------------------------------------------------------------ The Next 800 Companies to Lead America's Growth: New Video Whitepaper David G. Thomson, author of the best-selling book "Blueprint to a Billion" shares his insights and actions to help propel your business during the next growth cycle. Listen Now! http://p.sf.net/sfu/SAP-dev2dev _______________________________________________ Freevo-devel mailing list Freevo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freevo-devel
