Redzinalds Knipsis wrote:
Hello Doug,
I do not have this remote, but just an idea. After applying your patch
to kaa (see Recordserver crash on rel-1 SVN) my remote stopped working
as well. I had to remove patch to get it back.
Actually Freevo did not respond to keyboard as well while with patch,
so may be it is not the case.
Reggie,
No, you were right, the patch was garbage. Chalk it up to my lack of
experience in python. If you need it, attached is a patch that should
work correctly.
Thanks for the help, my patch was the problem, creating an infinite loop
that caused the GUI to stop responding to any events at all.
-Doug
Index: base/src/notifier/pynotifier/nf_generic.py
===================================================================
--- base/src/notifier/pynotifier/nf_generic.py (revision 2907)
+++ base/src/notifier/pynotifier/nf_generic.py (working copy)
@@ -204,9 +204,22 @@
r = w = e = ()
try:
- r, w, e = select( __sockets[ IO_READ ].keys(),
+ # According to this thread: http://mail.python.org/pipermail/medusa-dev/2000/000586.html
+ # the select call can raise EINTR which is safe to ignore and retry. Should really
+ # shore this up with a retry counter that raises the EINTR after some number of loops
+ # so we can avoid an infinite loop
+ while 1:
+ try:
+ r, w, e = select( __sockets[ IO_READ ].keys(),
__sockets[ IO_WRITE ].keys(),
__sockets[ IO_EXCEPT ].keys(), timeout / 1000.0 )
+ break
+ except select_error, v:
+ if v[0] != EINTR:
+ raise
+ else:
+ log.exception("got EINTR exception in select, will RETRY, code: %d" % v[0])
+ log.exception("Left select")
except ( ValueError, select_error ):
log.exception( 'error in select' )
sys.exit( 1 )
-------------------------------------------------------------------------
SF.Net email is sponsored by: The Future of Linux Business White Paper
from Novell. From the desktop to the data center, Linux is going
mainstream. Let it simplify your IT future.
http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
_______________________________________________
Freevo-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freevo-users
