On Fri, Feb 09, 2007 at 12:47:46AM +0000, Thorsten Glaser wrote:
> Please do not Cc: me on mails to the mailing lists (except -users@),
> because I'm subscribed to them. Thanks.
Ok, was a bad idea, i know. Wasn't just clear enough for me who the mail
belongs to before.
> Phil Sutter dixit:
> >Your changes introduce two obvious bugs, one of them was already
> >corrected by Dirk.
>
> Which would be the other one? That "missing" space there is
> intended, because sed prepends <space>-N<space>.
| T="--strip-unneeded $T$(${prefix}nm $F | sed -n \
| [...]
| eval "$T $F"
This can't work. If you really tested this, then you must have forgotten
to check the result. Maybe you committed something else than what you've
tested. It's quite hard for me to believe you really checked in such
lousy mistakes in the script.
> >Also I doubt if your params to sed do the same as
> >intended by the script I took from OpenWrt.
>
> I even tested it. And the reasons: cleaner and faster code,
> less external tools used, more portable.
Well again, what did you test? Evaluating only the first parts of the
code i cited above leads to something like:
'--strip-unneeded ${prefix}strip -R .comment'. I can't believe this is a
valid command, even with MirOS it shouldn't.
Next point is the second call to sed, using params I don't understand
after reading the fourth time. You are really shure it does the same
like before, i.e. finding all __module_parm_* symbols in the file,
appending the * part preceeded by '-K ' to the strip commandline?
In my eyes your code finds all lines containing __module_parm_, replaces
everything from beginning of the line to __module_parm_ inclusively with
' -K ' and that's it.
Greetings, Phil
_______________________________________________
freewrt-developers mailing list
[email protected]
https://www.freewrt.org/lists/listinfo/freewrt-developers
