Hi,
On Mon, Feb 23, 2009 at 08:17:34PM +0100, Clemens Helfmeier wrote:
> I have had a look at your patch and the differences between the two resulting
> busybox versions (busybox patched with your patch and busybox patched as i
> have
> it in the my local tree). There are a few things that are important:
>
> * IPKG works with mine and doesn't with your's, I think the following points
> are
> responsible for that:
> archival/libipkg/pkg_extract.c (3 times):
> Your Version:
> //archive->flags |= ARCHIVE_EXTRACT_UNCONDITIONAL;
> My Version:
> archive->ah_flags |= ARCHIVE_EXTRACT_UNCONDITIONAL;
>
> The archive->flags variable has been renamed, so we need to change the name in
> the ipkg patch, as well. I think I had found this after posting my initial
> patch
> to the list.
Looks like this was a "fast fix" when trying to get it compile I forgot
later to look at.
> I don't yet know weather the open_transformer dependency for ipkg is still
> valid. I have removed it from the archival/libunarchive/Kbuild file:
> lib-$(CONFIG_IPKG) += open_transformer.o
> decompress_unzip.o
> get_header_tar.o get_header_tar_gz.o
You say we need it, so please resend the patch. (The easier testing our
changes is, the better.)
> Why did you choose to make a few arguments in archival/libipkg/* (e.g. args.c)
> const char *varname;
> instead of
> char *varname;
> I guess we should stick to your version here, too. I have no real idea, what
> is
> best.
When doing compile fixing I also tried to eliminate most of the compiler
warnings. The s/char/const char/ changes aren't really a problem, it's
more for conformity's sake. But when there are too many of them, one
likely misses the real ones.
> As of my patch (see attachement) the busybox ipkg works on wl500gp-brcm-2.4.
> It
> can install and remove packages. The packages are usable in between those two
> tasks ;-)
Fine.
> * Shadow Passwords: I agree with your shadow.h include file. I have not tested
> shadow passwords, yet.
Me neither. ;)
> * insmod: i have no idea, where the segfault happens. I think, it is related
> with stack corruption (maybe some array-boundary problems?), since the core
> dump
> says, the program counter is at address 0x08. I have libefence included into
> the busybox but this didn't yield any useful information, I don't know if that
> is because of broken libefence, broken include into busybox or missing
> hardware
> features on mipsle...
Well, strange thing is that it works with the older version of busybox.
So something critical must have been changed in the insmod code since
then. I guess this should be the first point to check.
> Why is it, i do not have a bbconfig.small in my tree? there is only
> bbconfig.norm (which is "small" in menuconfig, i guess) and bbconfig.full
> (which could be "full featured" in menuconfig).
Sorry, my fault. Of course I meant bbconfig.full instead, so the changes
from bbconfig.norm need to be merged to bbconfig.full (and maybe
bbconfig.ipv6, too?).
Greetings and thanks so far,
Phil
_______________________________________________
freewrt-developers mailing list
[email protected]
https://www.freewrt.org/lists/listinfo/freewrt-developers
