Ralf Hemmecke wrote:
>
> Waldek,
>
> Instead of changing INSTALL.aldor, I'd like to get your permission to
> add the following patch.
>
> I've tested it with and without Internet. And I don't see where else it
> can go wrong.
>
> I somehow don't like the 3 ifs so much, but I don't know how to make it
> shorter.
>
> Ralf
>
1) I think than in rules instead of ifs it is better to use
construct like this:
$(CATURL) $(ALDORLANG)/$@ > [EMAIL PROTECTED] && mv [EMAIL PROTECTED] $@
(and let the clean rule remove trash files).
2) If you define
CATURL:=echo Get the file manually from
then it looks that the *.as rules will silently produce
files containing error message, so we will still have
problem. We should rather add extra rule which checks if
the needed files are present and stops build with error
message otherwise.
3) I also think that even if problem with restarting make is
fixed current INSTALL.aldor is misleading by omission:
it says to fetch extra files after make fails, while
if failure is expected than the most convenient moment
is after configure. So, while running make clean may
be unnecessary, other changes to INSTALL.aldor still apply.
Let me also say that I consider changing INSTALL.aldor a
low cost option: I checked that the procedure works on
my machine and it is reasonable to expect that it will
cause no extra breakage on other machines. OTOH changes
to Makefiles require testing. Still, if you want to
change Aldor interface Makefiles please go on.
--
Waldek Hebisch
[EMAIL PROTECTED]
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/fricas-devel?hl=en
-~----------~----~----~----~------~----~------~--~---
