On Fri, Oct 9, 2009 at 8:55 PM, Waldek Hebisch  wrote:
>
> Bill, I am not sure if I was clear enough.  I think that we should
> commit your patch from Septeber 12 with extra applyQuote chunk.
> The OrderedSet to Comparable change in op.spad.pamphlet should go
> in a separate patch together with patch to FreeModuleCategory.
>
> Can you do this?
>

Ok, done. It took me two commits to get it right. The 2nd commit
reverted some changes I did not intend to make (yet). Below is the end
result.

Regards,
Bill Page.

wsp...@debian:~/fricas-sources$ svn diff -r 677:head
Index: src/algebra/op.spad.pamphlet
===================================================================
--- src/algebra/op.spad.pamphlet        (revision 677)
+++ src/algebra/op.spad.pamphlet        (revision 679)
@@ -380,7 +380,7 @@
     opacsch := operator('acsch, 1)
     opbox   := operator('%box)$OP
     oppren  := operator('%paren)$OP
-    opquote := operator('applyQuote)$OP
+    opquote := operator('%quote)$OP
     opdiff  := operator('%diff, 3)
     opsi    := operator('Si, 1)
     opci    := operator('Ci, 1)
Index: src/algebra/fspace.spad.pamphlet
===================================================================
--- src/algebra/fspace.spad.pamphlet    (revision 677)
+++ src/algebra/fspace.spad.pamphlet    (revision 679)
@@ -220,7 +220,7 @@
     operator op ==
       is?(op, PAREN) => oppren
       is?(op, BOX) => opbox
-      error "Unknown operator"
+      error concat("Unknown operator 1: ",string(name(op)))$String

     mainKernel x ==
       empty?(l := kernels x) => "failed"
@@ -250,14 +250,14 @@
       s

     kernel(op:OP, args:List %) ==
-      not belong? op => error "Unknown operator"
+      not belong? op => error concat("Unknown operator 2:
",string(name(op)))$String
       okkernel(op, args)

     okkernel(op, l) ==
       kernel(op, l, 1 + reduce("max", [height f for f in l], 0))$K :: %

     elt(op:OP, args:List %) ==
-      not belong? op => error "Unknown operator"
+      not belong? op => error concat("Unknown operator 3:
",string(name(op)))$String
       ((u := arity op) case N) and (#args ~= u::N)
                                     => error "Wrong number of arguments"
       (v := evaluate(op,args)$BasicOperatorFunctions1(%)) case % => v::%
@@ -556,7 +556,7 @@
     equaldiff : (K,K)->Boolean
     debugA: (List % ,List %,Boolean) -> Boolean
     opdiff := operator('%diff)$CommonOperators()
-    opquote := operator('applyQuote)$CommonOperators
+    opquote := operator('%quote)$CommonOperators

     ground? x                == retractIfCan(x)@Union(R,"failed") case R
     ground  x                == retract x
@@ -573,7 +573,7 @@
     operator op ==
       is?(op, '%diff) => opdiff
       is?(op, '%quote) => opquote
-      error "Unknown operator"
+      error concat("Unknown operator 4: ",string(name(op)))$String

     if R has ConvertibleTo InputForm then
       INP==>InputForm
Index: ChangeLog
===================================================================
--- ChangeLog   (revision 677)
+++ ChangeLog   (revision 679)
@@ -1,3 +1,8 @@
+2009-10-10  Bill Page  <[email protected]>
+
+        * Fix bug: Error detected within library code: Unknown operator
+        * change 'applyQuote to '%quote
+
 2009-10-10  Ralf Hemmecke  <[email protected]>

        * configure.ac src/aldor/Makefile.in src/aldor/Makefile3.in
wsp...@debian:~/fricas-sources$

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"FriCAS - computer algebra system" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/fricas-devel?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to