Ralf Hemmecke wrote:
>
> Oh, btw, why do we still have src/interp/patches.lisp? We are using
> version control now. Why patch?
>
Now patches.lisp is just ordinary source file like others. Eventually
I would like to consolidate sources into smaller number of files.
However this is relatively low priority and ATM patches contains
things for which I did not found better place quickly.
> In fact, my previous patch should actually live in setq.lisp. No?
Maybe. But actually setq.lisp is a candiate for removal: I would
prefer to keep variables and code using them together.
> Another thing is |/MAJOR-VERSION|. What is this for?
>
> >grep -iR '/MAJOR.*-VERSION' *
> src/interp/setq.lisp:(SETQ |/MAJOR-VERSION| 7)
> src/interp/patches.lisp:(setq /MAJOR-VERSION 2)
> src/interp/patches.lisp:(defun /versioncheck (n) (unless (= n
> /MAJOR-VERSION) (throw 'versioncheck -1)))
> src/interp/lisplib.boot: then
> outputLispForm('VERSION,['_/VERSIONCHECK,_/MAJOR_-VERSION])
>
> Seems like checking the version number of .spad files, but why then
> setting it twice to 2 or 7?
>
I tried to remove such nonsense, but somewhat overlooked /MAJOR-VERSION.
Given that /versioncheck is the only user of /MAJOR-VERSION it
makes sense to keep them together and remove definition from setq.lisp.
--
Waldek Hebisch
[email protected]
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/fricas-devel?hl=en.
